using ArrayList for counting

Question

on my following code, I have 2 counters so I used an ArrayList , as I want to get number of each counted items outside loop. I've used arrayList as follow which gives me the expected values at print, but I would like to know if I can optimize my code using array [] , collections instead of list to avoid to to twice list.add(cout1);list.add(count2)?

ArrayList<Integer> list = new ArrayList<Integer>();
      int count1 = 0;
      int count2 = 0;

      for (int i = 0; i < nb; i++)
      {

        if (action)
        {
          counter1++;

        }
        if (votherAction)
        {
          counter2++;

        }

      }
    list.add(count1);
    list.add(count2);

It is very unclear what you mean. If you know you have two counters, and you have two variables for them, why do you want to put them into a collection? And what do you mean by tables? — Björn Pollex
– Björn Pollex, Commented Oct 14, 2011 at 7:19
I just want to count number of string1 if(action1) number of strings2 if(action2) so I have 2 counters , and I would like to know if there a a way to make the cound without adding twice count1,count2 to the list? — lola
– lola, Commented Oct 14, 2011 at 7:26

SirVaulterScoff · Accepted Answer · 2011-10-14 12:32:13Z

2

You can use FluentUtils.pair() instead of ArrayList (http://code.google.com/p/fluentutils/) like return pair(counter1, counter2)

answered Oct 14, 2011 at 12:32

SirVaulterScoff

7041 gold badge6 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Konstantin Pribluda · Accepted Answer · 2011-10-14 07:26:30Z

0

Use to produce arraylist: Arrays.asList(count1, count2)

answered Oct 14, 2011 at 7:26

Konstantin Pribluda

12.3k1 gold badge33 silver badges38 bronze badges

1 Comment

lola Over a year ago

ok, so here I have to remove : ArrayList<Integer> list = new ArrayList<Integer>(); ?

Xavier Combelle · Accepted Answer · 2011-10-14 07:31:03Z

0

you can do that

int[] counter = new int[2];

      for (int i = 0; i < nb; i++)
      {

        if (action)
        {
          counter[0]++;

        }
        if (votherAction)
        {
          counter[1]++;

        }

      }

but the benefice is minimal

answered Oct 14, 2011 at 7:31

Xavier Combelle

11.3k5 gold badges30 silver badges53 bronze badges

Comments

Vaandu · Accepted Answer · 2011-10-14 07:34:10Z

0

You can just add them to a String and need not to use ArrayList. You can use this to print.

String counterStr = "Count 1 : " + count1 + ", Count 2 : " + count2;

Edit: You can use Array instead of ArrayList.

int[] countArr = new int[2];
...
countArr[0] = counter1;
countArr[1] = counter2;

edited Oct 14, 2011 at 7:34

answered Oct 14, 2011 at 7:28

Vaandu

4,99112 gold badges51 silver badges76 bronze badges

3 Comments

lola Over a year ago

no, I didn't use only to print , I would like to use values of my count1, count2 outside the loop and would like to know if there is a better way then mine to do it

lola Over a year ago

I have to use the content of counters outside loop

Vaandu Over a year ago

You can use countArr outside.

Collectives™ on Stack Overflow

using ArrayList for counting

4 Answers 4

Comments

1 Comment

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related