How to run given javascript code given in the following example?

Question

I am trying to run a javascript code but it is not running. I don't know why? Here is the code sample:

Javascript:
<Script Language="text/Javascript">
function validateForm()
{
var x=document.forms["form1"]["Injection"].value;
var y=document.forms["form1"]["limit"].value;
if (x==null || x=="")
  {
  alert("Injection must be filled out");
  return false;
  }
if (y==null || y=="")
  {
  alert("Limit must be filled out");
  return false;
  }
  return true;
}
</Script>

HTML:

        <form  name="form1" method="post" action="/OT_Stock/addnewinjection.jsp" onsubmit="return validateForm()"> 

        <input type="text" name="Injection" maxlength="100" size="20" value="" style="textfield">
         <input type="text" name="limit" maxlength="100" size="20" value="" style="textfield" >



        <input type="submit"  value="Add Name" class="buttonmain">

Please tell me where I am going wrong?

Jamiec · Accepted Answer · 2011-10-14 09:48:45Z

2

Remove the onclick from the button
Add onsubmit="return validateForm()" to the form element.

The crucial bit is the return keyword. Without it the form will always submit. With it, when the validateForm method returns false (invalid form) the form will not submit.

Edit: OP has updated his question with the above suggestions.

edited Oct 14, 2011 at 9:48

answered Oct 14, 2011 at 8:10

Jamiec

136k15 gold badges143 silver badges202 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Samiksha Over a year ago

I made all changes still its not working. Why Please tell me??

Jamiec Over a year ago

@Samiksha - works for me: jsfiddle.net/pRVP5 - check other javascript is not erroring on your page. If you want further help define "not working".

Samiksha Over a year ago

There is no other javascript on my page. Not working means even though I click submit with blank fields the page is not returning.

Jamiec Over a year ago

@Samiksha - What do you mean "the page is not returning"? Returning what? If you click submit with blank fields a javascript alert should popup and the page not submit... thats what your code implies you're trying to achieve!

Samiksha Over a year ago

Ya that's right but page is submitting to the page specified even though i am submitting with blank fields. Don't know why?

|

bhups · Accepted Answer · 2011-10-14 08:18:39Z

0

forma name is " form1", instead of it should be "form1".
Don't use language in the script tag instead use type='text/javascript'.

answered Oct 14, 2011 at 8:18

bhups

15k8 gold badges53 silver badges57 bronze badges

Collectives™ on Stack Overflow

How to run given javascript code given in the following example?

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related