JQuery JSON - Using variables

Question

OK let's say I have this:

<!DOCTYPE html>
<html>
<head>
  <style>img{ height: 100px; float: left; }</style>
  <script src="http://code.jquery.com/jquery-latest.js"></script>
</head>
<body>
  <div id="images">
Hello<br />
</div>
<script>
$.getJSON("main.txt",
  function(data) {
    var getTitle = title;    
    $.each(data.getTitle, function(i,getTitle){
       $("#images").append(getTitle);
    });
  });</script>
</body>
</html>

it doesn't work because of var getTitle = title. I know that. But if I take out the var and replace getTitle with title which is INSIDE the JSON file.. it WILL work. But I don't want to edit three pieces of title for each code so I just make a variable so I can edit all three at once... but it doesn't work...

I dont't understand what do you try to do. what is title - is it defined somewhere? — Guard
– Guard, Commented Oct 15, 2011 at 19:43
@Guard, Its a typo, he meant var getTitle = "title"; The point being if the JSON changes, that he only has to change the value of getTitle.. I agree that it wasn't massively clear though. — stevenrcfox
– stevenrcfox, Commented Oct 15, 2011 at 19:59

Vivek Viswanathan · Accepted Answer · 2011-10-15 19:42:51Z

2

Instead of accessing the object as data.getTitle, try using [].

var getTitle = "title";
$.each(data[getTitle], function(........)

This would solve the problem.

answered Oct 15, 2011 at 19:42

Vivek Viswanathan

1,96318 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eric · Accepted Answer · 2011-10-15 20:12:16Z

I just make a variable so I can edit all three at once

That doesn't make any sense. The name of the variable doesn't matter at all. For what you're doing, this works just as well:

$.getJSON('main.txt', function(data) {
    $.each(data.title, function(i, anyVariableNameILikeGoesHere) {
        $('#images').append(anyVariableNameILikeGoesHere);
    });
});

However, jQuery actually provides a more concise way of writing this:

$.getJSON('main.txt', function(data) {
    $.each(data.title, function() {
        $('#images').append(this);
    });
});

Aside from that though, why are you iterating over data.title? Looking at your json, it's a single string! This is a much better way to write it:

$.getJSON('main.txt', function(data) {
    $('#images').append(data.title);
});

Collectives™ on Stack Overflow

JQuery JSON - Using variables

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related