Variable Declaration inside an IF C#

Question

take a look at the following code :

if( down == null || down.GetFace() != Face.None || down.GetFace() != Face.Partial )
{  
    // I called GetFace() two times
    // How can i avoid to call it two times, and still putting inside that if
}

Thank you!

It better to ask the question as part of the question body and not as a comment within your code sample. People could miss it. — Oded
– Oded, Commented Oct 24, 2011 at 9:16

Mohamed Abed · Accepted Answer · 2011-10-24 09:20:14Z

2

To be more maintainable and expressive first separate the null check as exceptional case

then get the result to a variable and check it.

if(down == null)
  // Some exceptional case .. return or throw exception

var result =  down.GetFace();
if(result == Face.None || result != Face.Parial)
  // Do your code here

answered Oct 24, 2011 at 9:20

Mohamed Abed

5,13124 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Oded · Accepted Answer · 2011-10-24 09:22:29Z

1

Refactor to a method:

private bool IsFaceNoneOrPartial(Down down)
{
   var face = down.GetFace();

   return face != Face.None || face != Face.Partial;
}

// Your code is now:
if( down == null || IsFaceNoneOrPartial(down))
{

}

answered Oct 24, 2011 at 9:22

Oded

501k102 gold badges900 silver badges1k bronze badges

Collectives™ on Stack Overflow

Variable Declaration inside an IF C#

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related