Why is my JavaScript code not working?

Question

I keep getting the "Syntax Error: Unexpected identifier" JS error with this code:

function hashStuff() {
    var messageID = window.location.hash.replace('#inbox-', '');
    var msgSubject = $('#subject_' + messageID).html();
    setTimeout("readMessage2(" + messageID + ", " + msgSubject + ");", 300);
}
if (window.location.hash) {
    setTimeout("hashStuff();", 400);
}

I've also tried:

if (window.location.hash) {
    function hashStuff() {
    var messageID = window.location.hash.replace('#inbox-', '');
    var msgSubject = $('#subject_' + messageID).html();
    setTimeout("readMessage2(" + messageID + ", " + msgSubject + ");", 300);
}
    setTimeout("hashStuff();", 400);
}

Neither of them work.

What I was trying to do was get information from the elements but I guess the page wasn't loaded yet so I need it to trigger after a second. I put it in a function so I can use a timeout and it will not work.

Any ideas? Thanks in advance.

avoid using timers, very inconsistent, just use the jQuery ready — Kris Ivanov
– Kris Ivanov, Commented Oct 25, 2011 at 22:18
To the person who downvoted: thanks for commenting about why you downvoted! :| — Nathan
– Nathan, Commented Oct 25, 2011 at 22:20
Your title kind of sucks. You are creating a string to eval using setTimeout - I bet those parameters need quotes. — James
– James, Commented Oct 25, 2011 at 22:29
@Nathan well you could maybe figure out the line of code with the syntax error, take a guess at the part of the line that's causing it, and make up a title like "Why does 'foo..bar' cause a syntax error?" Even if "foo..bar" isn't the cause, it's still more specific that, essentially, "Halp!!". — Pointy
– Pointy, Commented Oct 25, 2011 at 22:57

Niet the Dark Absol · Accepted Answer · 2011-10-25 22:15:46Z

4

If your messageID is something like 1234 and the msgSubject is Hello World, then the statement being evaluated is:

readMessage2(1234, Hello World);

Which, clearly, is incorrect and error-inducing.

The correct code is:

setTimeout( function() {readMessage2(messageID,msgSubject);}, 300);

answered Oct 25, 2011 at 22:15

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lycha · Accepted Answer · 2011-10-25 22:16:13Z

2

You can run the script inside $(document).ready(function() {//script here}); . That will make sure that it is run after all the elements have loaded.

answered Oct 25, 2011 at 22:16

Lycha

10.2k3 gold badges40 silver badges43 bronze badges

3 Comments

Nathan Over a year ago

Yeah, I'm surprised I didn't think of that. Thanks!

Nathan Over a year ago

But another problem is that it keeps repeating. So it keeps repeatedly calling the readMessage2() function now with document.ready over and over and over again. What part was I supposed to put in the .ready, the whole if() or just a part of it?

Lycha Over a year ago

@Nathan You were supposed to put the code you wanted to run in the first place (get messageID and msgSubject and call readMessage2() I guess). No need for setTimeout() if I understood correctly.

Kris Ivanov · Accepted Answer · 2011-10-25 22:16:58Z

0

try wrapping your code inside ready block:

$(document).ready(function () {
    //your code
});

answered Oct 25, 2011 at 22:16

Kris Ivanov

10.6k2 gold badges26 silver badges36 bronze badges

Collectives™ on Stack Overflow

Why is my JavaScript code not working?

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related