Python 'int' object is not subscriptable

Question

Im trying to read a file and make sure that each value is in order. I dont think im converting the string into the integer correctly. Here is some of my code. I am also trying to use flags.

fileName = input("What file name? ")
infile = open(fileName,'r')
correct_order_flag = False
i = 0
line = infile.readline()
while line !="": 
    for xStr in line.split(" "):
        if eval(xStr) [i] < i:
            correct_order_flag = True
        else:
            correct_order_flag = False
    i = i+1
if correct_order_flag:
    print("Yes, the numbers were in order")
else:
    print("No, the numbers were not in order")
count = i - 1
print("There were", count, "numbers.")

Jakob's comment was inappropriate. Pythonistas tend to avoid using eval() because it can present a security risk when evaluating untrusted data. There are legitimate use cases for eval(), but this isn't one of them because the str() function will do what you want. — Raymond Hettinger
– Raymond Hettinger, Commented Oct 30, 2011 at 22:19

Chris Bunch · Accepted Answer · 2011-10-30 22:01:33Z

4

You are correct - you are indicating with eval(xStr)[i] that eval(xStr) is an array, and thus can be subscripted. What it looks like you may want (since you say you want to convert the string to an int) is just int(xStr), to make that whole line:

if int(xStr) < i:

answered Oct 30, 2011 at 22:01

Chris Bunch

90.5k37 gold badges130 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zaur Nasibov · Accepted Answer · 2011-10-30 22:02:12Z

1

For starters, you don't read the whole file at all. Try this:

with open(fileName) as f:
    for line in f:
        # here goes your code

Not sure though, what do you mean by "each value is in order", but using eval() is a VERY bad idea for any purpose.

answered Oct 30, 2011 at 22:02

Zaur Nasibov

22.7k12 gold badges60 silver badges86 bronze badges

Comments

HuntR2 · Accepted Answer · 2011-10-30 22:16:29Z

0

I would like to add that because you are comparing xstr[i] to i that unless your first number is less than zero the flag will change, meaning that the sequence 1 2 3 4 5 would print out saying "NO, the numbers were not in order"

answered Oct 30, 2011 at 22:16

HuntR2

1494 bronze badges

Comments

Raymond Hettinger · Accepted Answer · 2011-10-30 22:16:50Z

0

As Chris indicated, int(s) is the preferred way to convert a string to an integer. eval(s) is too broad and can be a security risk when evaluating data from an untrusted source.

In addition, there is another error in the script. The *correct_order_flag* is being set on every iteration, so one entry with incorrect order can be masked by a subsequent entry in the correct order. Accordingly, you should break out of the loop when incorrect ordering is found.

answered Oct 30, 2011 at 22:16

Raymond Hettinger

229k67 gold badges405 silver badges504 bronze badges

Collectives™ on Stack Overflow

Python 'int' object is not subscriptable

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related