JavaScript function not working for string values

Question

ASP.NET Webform ListView ItemTemplate passing a value to a JavaScript function works correctly if the item_id is numeric. But I get this error if the item_id is alpha-numeric.

Uncaught ReferenceError: pf10001 is not defined
    at HTMLAnchorElement.onclick (Products.aspx:1182:163)

<a href="#" class="btn btn-sm btn-success" onclick='<%# "javascript:AddToCart(" + DataBinder.Eval(Container.DataItem, "item_id") + ");return false;" %>'>Add to Cart</a>

function AddToCart(item) {
    PageMethods.AddToCart(item, 0, onRequestComplete);
};

Have tried various hidden fields to pass the item_id value without success. But I'm wondering if there's a simple answer to this error.

You need to encapsulate the ID in quotes if it is alphanumeric. You don't need javascript: scheme in an onclick attribute, so it could just be onclick='<%# "AddToCart(\"" + DataBinder.Eval(Container.DataItem, "item_id") + "\");return false;" %>'>, but it's been a while since I touched a Webform, so this is a guess :). — Heretic Monkey
– Heretic Monkey, Commented May 26 at 17:57
Alternately, take a page out of Thymeleaf's approach and use data attributes — Phil
– Phil, Commented May 26 at 22:34

OfficialVysko · Accepted Answer · 2025-05-26 20:15:18Z

0

You’re rendering this in HTML:

<a onclick="AddToCart(pf10001);return false;">

(without quotes), so JS treats pf10001 as an undefined variable.

Solution

To actually emit quotes around the ID, you have to include them in the literal string you’re building this way:

<a href="#"
   class="btn btn-sm btn-success"
   onclick='<%# "AddToCart(\'" + Eval("item_id") + "\');return false;" %>'>
   Add to Cart
</a>

answered May 26 at 20:15

OfficialVysko

1556 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JavaScript function not working for string values

1 Answer 1

Solution

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Solution

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related