Database not updating, using C# and Windows forms [closed]

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.

This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.

Closed 3 months ago.

Improve this question

I have a SQL database being locally hosted that keeps track of stock, I'm trying to get the SQL command "UPDATE stock SET cantidad = 530 WHERE id = 0" through using a C# Windows form application. But I'm having no changes made on the codebase

For this, I've made a function "setCantidad", but it isn't working. I'm getting no errors, just no changes in the codebase. All the other functions, which are made similarly to this one, work well. The SQL command, when inputted directly into the codebase, works well.

Here's the function

public void setCantidad(int valorActualizado, int indice)
{
    Conexion miConexion = new Conexion();
    conectar = miConexion.GetConnection();
    conectar.Open();
    sql = "UPDATE stock " + "SET cantidad = " + valorActualizado + " WHERE id = " + indice;
    MySqlCommand comando = new MySqlCommand(sql, conectar);
    conectar.Close();
}

The value of the SQL variable is sql = UPDATE stock SET cantidad = 530 WHERE id = 0 once it reaches conectar.Close, so I doubt it's that.

comando.ExecuteNonQuery() is required before closing the connection. — Wyck
– Wyck, Commented Sep 2 at 19:43
Unrelated, but this is also a good time to start using parameterized queries. — David
– David, Commented Sep 2 at 19:43
The following may be of interest: stackoverflow.com/a/68510196/10024425 (see code block for HelperMySql.cs) — It all makes cents
– It all makes cents, Commented Sep 2 at 19:53
Okay the issue has been solved. I wasn't using a reader to actually read the MySqlCommand. I deserve to be put in front of a firing squad — Joelkoellner Koellner
– Joelkoellner Koellner, Commented Sep 2 at 20:02

Charlieface · Accepted Answer · 2025-09-02 19:55:17Z

2

You need to actually execute the command, not just create it. It won't run by itself.

You should also parameterize your query, and have using on any disposable objects.

public void setCantidad(int valorActualizado, int indice)
{
    Conexion miConexion = new Conexion();
    using var conectar = miConexion.GetConnection();
    conectar.Open();
    const string sql = @"
UPDATE stock
SET cantidad = @valorActualizado
WHERE id = @indice;
";
    using var comando = new MySqlCommand(sql, conectar);
    comando.Parameters.Add("@indice", SqlDbType.Int).Value = indice;
    comando.Parameters.Add("@valorActualizado", SqlDbType.Int).Value = valorActualizado;
    comando.ExecuteNonQuery();
}

Consider also using async and await if possible.

answered Sep 2 at 19:55

Charlieface

78.4k8 gold badges35 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Database not updating, using C# and Windows forms [closed]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related