C# string manipulation Regex or substring?

Question

I have a

string CCstring = "CC01=50 CC02=300 CC03=500 CC04=40";

I want to store the individual values in seperate strings like:

for(int i = 0; i<=4; i++)
{
   string suffix = i.ToString().PadLeft(2, '0');
   string CCindividual = CCindividual + i;
   CCindividual = //THIS IS WHERE I WOULD LIKE TO GET MY INDIVIDUAL VALUES i.e 50,300,500,40;
    Console.WriteLn("CC" + i + " =" + CCIndividual);//Testing
}

Which string manipulation should I use Regex or Substring. How would the code snippet look like?

Old chinese proverb: When face with problem, programmer may decide to use Regex. Programmer now have 2 problem. — Jamiec
– Jamiec, Commented Nov 2, 2011 at 14:28
@Jamiec: Didn't know that Jamie Zawinski was chinese :-p (regex.info/blog/2006-09-15/247) — Joachim Rohde
– Joachim Rohde, Commented Nov 2, 2011 at 14:53
@Joachim - funnily enough I kinda knew that wasnt really a chinese proverb. It's just funnier framed as one. — Jamiec
– Jamiec, Commented Nov 2, 2011 at 14:57

Otiel · Accepted Answer · 2011-11-02 14:37:54Z

3

One line:

string[] CCindividual = Regex.Split(CCstring, "CC[0-9]+=").Where(x => x != "").
    Select(x => x.Trim()).ToArray<String>();

Not sure this is the more efficient way though.

edited Nov 2, 2011 at 14:37

answered Nov 2, 2011 at 14:28

Otiel

18.8k17 gold badges82 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Sam Over a year ago

Thank you. The snippet: string[] CCindividual = Regex.Split(tempComms, "CC[1-9]+="); worked perfectly. I also have other generated elements like CCundefined which are created by JS on unused inputs. Regex elimated that too. Other solutions described here were making it too complicated then its actually is. I know Regex has a beautiful way to simplify complex string operation. Just could not make one. Thanks again.

Sam Over a year ago

The edited version works too. Can you explain what is different in the edited version from the original version and why was it made?

Otiel Over a year ago

@SameerShah: I added .Where(x => x != "") to remove empty values that you can obtain after doing the Regex.Split, and Select(x => x.Trim()) to remove any trailing spaces (without it, you will obtain 50_, 300_, 500_ and 40, _ representing a space here).

Sam Over a year ago

I got it. I also would like to remove any alphabets For Eg:

string tempComms = "CC01=500 CC02=50 CC03=400 CC04=undefined CC06=Blah CC07=4Blah"; string[] CCIndividualEdited = Regex.Split(tempComms, "CC[0-9]+=").Where(x => x != "").Where(x => x != "^[a-zA-Z]+$").Select(x => x.Trim()).ToArray<String>();

How should I do that.

Sam Over a year ago

You mean like this:

string[] Comm = Regex.Split(tempComms, "CC[1-9]+=").Where(x => x != "").Where(x => x = Regex.Match( "[0-9]+")).Select(x => x.Trim()).ToArray<String>();

|

Pieter · Accepted Answer · 2011-11-02 14:27:19Z

2

Can't you use split to first split on spaces and next on '='? It's easier than regex or substring imho.

answered Nov 2, 2011 at 14:27

Pieter

3,3975 gold badges34 silver badges69 bronze badges

Comments

Femaref · Accepted Answer · 2011-11-02 14:35:31Z

2

Neither. You can use string.Split to get an array:

string CCstring = "CC01=50 CC02=300 CC03=500 CC04=40";
string[] strings = CCstring.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);

After that, you are able to do the same for the = using string.Split(new char[] { '=' }, StringSplitOptions.RemoveEmptyEntries);.

edited Nov 2, 2011 at 14:35

answered Nov 2, 2011 at 14:26

Femaref

61.5k8 gold badges145 silver badges176 bronze badges

1 Comment

Otiel Over a year ago

You then have to remove "CCXX=".

ClearCarbon · Accepted Answer · 2011-11-02 14:29:09Z

1

Unless you need this code to run very very efficiently. You should be worried about what is readable for you and your team (sometimes thats substring, split etc and sometimes thats regex). Only you can really decide.

answered Nov 2, 2011 at 14:29

ClearCarbon

4594 silver badges13 bronze badges

Comments

Alexeyss · Accepted Answer · 2011-11-02 14:34:01Z

1

just use String.Split

        string CCstring = "CC01=50 CC02=300 CC03=500 CC04=40";
        var result = CCstring.Split(' ')
            .Select(s => s.Split('='))
            .ToDictionary(kv => kv[0], kv => Convert.ToInt64(kv[1]));

answered Nov 2, 2011 at 14:34

Alexeyss

3,2461 gold badge19 silver badges11 bronze badges

Comments

Sergei B. · Accepted Answer · 2011-11-02 14:31:46Z

0

Looking at your CCstring it will be definitely faster to walk through the string characters just once. Sure it doesn't worth that until you have tons of such strings.

So, yep, it's easier to use just string.Split once for spaces, and once for each fragmet to split by '='.

answered Nov 2, 2011 at 14:31

Sergei B.

3,23721 silver badges18 bronze badges

Collectives™ on Stack Overflow

C# string manipulation Regex or substring?

6 Answers 6

7 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

7 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related