PHP ignoring __set method inside the class

Question

I'm building a class with a number of input validations, and I've decided to place them inside a __set method (I'm not sure if this is proper form as I have limited OOP experience). This seems to work fine, throwing the proper errors when invalid values are passed from outside the class. However, if a variable is modified inside the class the _ _set method seems to be ignored alltogether.

Any insight would be hugely appreciated

//RESULT:::::::::::::::::::::::::::::::
// PASS: Testing : hello
// PASS: Testing exception handling
// __SET: Setting b to 123
// PASS: Testing with valid value: 123
// FAIL: Testing exception handling World2



 <?php
class Test {
        public $a;
        private $b;

        function __set( $key, $val ) {

                switch( $key ) {
                        case 'b':
                                if( !is_numeric( $val ) ) throw new Exception("Variable $b must be numeric");
                                break;
                }

                echo ( "__SET: Setting {$key} to {$val}<br/>" );
                $this->$key = $val;
        }
        function __get( $key ) { return $this->$key; }
        function bMethod() {
                $this->b = "World2";
        }

}

$t = new Test();

//testing a
try {
        $t->a = "hello";
        echo "PASS: Testing $a: {$t->a}<br/>";
} catch( Exception $e)  {
        echo "FAIL: Testing $a";
}

//testing b
try {
        $t->b = "world";       
        echo "FAIL: Testing $b exception handling<br/>";
} catch( Exception $e ){
        echo "PASS: Testing $b exception handling<br/>";
}

//testing b with valid value
try  {
        $t->b = 123;
        echo "PASS: Testing $b with valid value: {$t->b}<br/>";
} catch( Exception $e) {
        echo "FAIL: Testing $b";
}

//bypassing exception handling with method
try {
        $t->bMethod("world");
        echo "FAIL: Testing $b exception handling {$t->b}<br/>";
} catch( Exception $e ) {
        echo "PASS: Testing $b exception handling<br/>";
}

This had me foxed for at least an hour...

Jonathan
– Jonathan

2015-11-25 15:59:18 +00:00
Commented Nov 25, 2015 at 15:59 — Jonathan
– Jonathan, Commented Nov 25, 2015 at 15:59

NullUserException · Accepted Answer · 2011-11-13 18:00:01Z

11

Read the definition of __set: "__set() is run when writing data to inaccessible members." Inaccessible is key here. From within the class, all members are accessible and __set is bypassed. Overloading

edited Nov 13, 2011 at 18:00

NullUserException

85.8k31 gold badges212 silver badges239 bronze badges

answered Apr 28, 2009 at 18:49

jmucchiello

19k7 gold badges44 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

zombat Over a year ago

Unfortunately I'm out of votes today, but this is correct. I ran into this issue trying to emulate getters/setters from other languages. It just doesn't work the same.

Gaston · Accepted Answer · 2009-04-28 18:57:38Z

6

The documentation at the php documentation says:

__get() is utilized for reading data from inaccessible members.

So, you can do something like:

<?php
class Test {
    private $_params = array();

    function __set( $key, $val ) {
        ...
        $this->_params[$key] = $val;
    }

    function __get( $key ) {
        if (isset($this->_params[$key])) return $this->$key;
        throw Exception("Variable not set");
    }

    ...
}

answered Apr 28, 2009 at 18:57

Gaston

1,8782 gold badges15 silver badges29 bronze badges

1 Comment

thatcanadian Over a year ago

This feels like a bit of a hack, but it actually does exactly what I wanted to do; variable calls inside class methods can't call the variables directly, so they use the __set and __get function. Thanks!

Collectives™ on Stack Overflow

PHP ignoring __set method inside the class

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related