Php Header location error

Question

I have a php header location problem what i am doing is getting some data from my database and then making a if else check and depending on that i am redirecting the user to the next page ,here goes my code

            if($claim_status == 'Pending Verification')
        {
            $page = "pending-verification.php?verifyid=".$id."";
        }
        elseif($claim_status == 'Pending PO Clearance')
        {
            $page = "po-clearance.php?verifyid=".$id."";
        }
        elseif($claim_status == 'Payment Approved')
        {
            $page = "payment-approved.php?verifyid=".$id."";
        }
        elseif($claim_status == 'Payment Receipt')
        {
            $page = "confirm-claim.php?verifyid=".$id."";
        }
        elseif($claim_status == 'Billing')
        {
            $page = "billing.php?verifyid=".$id."";
        }
        elseif($claim_status == 'Billed')
        {
            $page = "billed.php?verifyid=".$id."";
        }
        header("Location:$page");

$claim_status is a variable i am getting from my database.

The error i am getting is ( this page has a redirect loop) how can i take care of this Please help me

Thank You

Try replacing the last header statement with print header("Location:$page"); -> print("Location:$page"); and see what gets printed. — Salman Arshad
– Salman Arshad, Commented Nov 4, 2011 at 12:25

Quentin · Accepted Answer · 2011-11-04 12:28:43Z

2

It appears you emit a Location header no matter what (the header statement isn't inside an if … at least not in the code you've shared), so it will always redirect (and always with a malformed Location header, even when $page is defined, it fails to be an absolute URI).

Only emit the Location when you actually want to redirect.

answered Nov 4, 2011 at 12:28

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dynamic · Accepted Answer · 2011-11-04 12:33:39Z

0

Not answering your question, but you should avoid so many else if. Your code should look like this:

$allowedStatus = array ( 
    'Pending Verification' => 'pending-verification',
    'Pending PO Clearance' => 'po-clearance'
    //> Etc
);

At this point is easy to build your $page var

$page = $allowedStatus[$claim_status] . '.php?verifyid=' . $id;

answered Nov 4, 2011 at 12:33

dynamic

48.2k56 gold badges163 silver badges236 bronze badges

Comments

John · Accepted Answer · 2011-11-04 12:41:06Z

0

Use case instead of if-elsif statements. Also, make sure there's no other php output before header();

switch($claim_status) {

    case 'Pending Verification':
        $page = "pending-verification.php?verifyid=".$id."";
        break;

    case 'Pending PO Clearance';
        $page = "po-clearance.php?verifyid=".$id."";
        break;

    case 'Payment Approved';
        $page = "payment-approved.php?verifyid=".$id."";
        break;

    case 'Payment Receipt';
        $page = "confirm-claim.php?verifyid=".$id."";
        break;

    case 'Billing';
        $page = "billing.php?verifyid=".$id."";
        break;  

    case 'Billed';
        $page = "billed.php?verifyid=".$id."";
        break;


    default:
        $page = ''; //Set a default rediraction page in case $claim_status is invalid.
        break;

}

header("Location:$page");

answered Nov 4, 2011 at 12:41

John

5572 silver badges6 bronze badges

2 Comments

dynamic Over a year ago

this is just bad as the else if, read my answer to get a better code

John Over a year ago

I saw it after i posted the answer. Much better version. Only thing you need to do, is to check if the array key exists so that the $page will be always valid. if (array_key_exists($claim_status, $allowedStatus)) { $page = $allowedStatus[$claim_status] . '.php?verifyid=' . $id; } else { $page = "error_handling.php"; }

Md. Saidur Rahman Milon · Accepted Answer · 2015-08-08 09:32:36Z

0

You may use javascript to stop redirection loop

<?php
   $redirect_page = 'page.php';
   echo "<script type='text/javascript'>window.location=$redirect_page</script>";
?>

answered Aug 8, 2015 at 9:32

Md. Saidur Rahman Milon

2,93125 silver badges29 bronze badges

Collectives™ on Stack Overflow

Php Header location error

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related