Converting a string of data to an array with PHP

Since values can contain dashes and be spread across multiple lines, I think the safest method for separating keys from values is using substr(), since the separating dashes always sit at the same character position in the string.

FIXED

<?php

  // first, split into lines
  $lines = explode("\n",str_replace(array("\r\n","\r"),"\n",$data));

  // this will hold the parsed data
  $result = array();

  // This will track the current key for multi-line values
  $thisKey = '';

  // Loop the split data
  foreach ($lines as $line) {
    if (substr($line,4,1) == '-') {
      // There is a separator, start a new key
      $thisKey = trim(substr($line,0,4));
      if ($result[$thisKey]) {
        // This is a duplicate value
        if (is_array($result[$thisKey])) {
          // already an array
          $result[$thisKey][] = trim(substr($line,5));
        } else {
          // convert to array
          $result[$thisKey] = array($result[$thisKey],trim(substr($line,5)));
        }
      } else {
        // Not a duplicate value
        $result[$thisKey] = trim(substr($line,5));
      }
    } else {
      // There is no separator, append data to the last key
      if (is_array($result[$thisKey])) {
        $result[$thisKey][count($result[$thisKey]) - 1] .= PHP_EOL.trim(substr($line,5));
      } else {
        $result[$thisKey] .= PHP_EOL.trim(substr($line,5));
      }
    }
  }

  print_r($result);

?>

See it working