php and get method error

Question

I have this code :

<?php
if ($_GET["do"]=="success") {
    echo "SUCCESS";
}
?>

<form action="file.php?do=success" method="post">
<input type="text"><input type="submit">
</form>

And I get this error:

Notice: Undefined index: do in C:\Program Files\EasyPHP-5.3.8.1\www\m\file.php on line 2

What do I need to do?

@budwiser: isn't the error already reported? Or are you suggesting to suppress the errors and pretend like it never happened? :P — PeeHaa
– PeeHaa, Commented Nov 15, 2011 at 22:29
@budwiser Given that the OP is seeing E_NOTICE errors, I'd say he's got it under control — Phil
– Phil, Commented Nov 15, 2011 at 22:29
Truthfully, that error isn't the end of the world. But with PHP5.3 we are having to code more strict. This is a good thing overall, but just make sure the var exists before moving down the code. — frustratedtech
– frustratedtech, Commented Nov 15, 2011 at 22:31
@DavidGuerra: Did you just say what I think you did? :o Suppressing errors / notices is NEVER a good idea. Either coding strict or not. Might be just be getting old though. Although I don't think so :D — PeeHaa
– PeeHaa, Commented Nov 15, 2011 at 22:34

PeeHaa · Accepted Answer · 2011-11-15 22:20:56Z

3

You need to check if the index exists before trying to access it:

<?php
if (isset($_GET["do"]) && $_GET["do"] == "success") {
    echo "SUCCESS";
}
?>

<form action="file.php?do=success" method="post">
<input type="text"><input type="submit">
</form>

answered Nov 15, 2011 at 22:20

PeeHaa

73.1k60 gold badges195 silver badges264 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Scott Harwell · Accepted Answer · 2011-11-15 22:21:51Z

1

Try this:

<?php
if (!empty($_GET['do']) && $_GET["do"]=="success") {
    echo "SUCCESS";
}
?>

<form action="file.php?do=success" method="get">
<input type="text"><input type="submit">
</form>

answered Nov 15, 2011 at 22:21

Scott Harwell

7,4652 gold badges31 silver badges41 bronze badges

4 Comments

Uğur Gümüşhan Over a year ago

@RobertasPalinskis use isset() rather than empty(). empty doesn't check if the value was set and returns errors on unset values. null is not "not set";

Scott Harwell Over a year ago

@UğurGümüşhan this is incorrect. empty() does test for the existence of an object. Review example 1A or test it in code: php.net/manual/en/function.empty.php

Uğur Gümüşhan Over a year ago

I know the documentation. "not set" is not NULL

Scott Harwell Over a year ago

"empty() is the opposite of (boolean) var, except that no warning is generated when the variable is not set." Empty will return no errors if a value is not set per the documentation. So, if empty is not set or has no value, then the conditions are not met and no errors are produced.

Collectives™ on Stack Overflow

php and get method error

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related