multiple file upload foreach error

Question

I have used the following code several times before, and have recently found it to try and use again. There now seems to be an error which I cannot fix, can anyone see what I am doing wrong?

foreach ($_FILES['image']['name'] as $i => $name) {     

    $uploadfile = $uploaddir . basename($name);

    if (!move_uploaded_file($file_post["tmp_name"][$i],$uploadfile)) 
    {
        echo set_e('error','Image ['.$i.'] not uploaded','');
    }


}

The error I get is

Warning: Invalid argument supplied for foreach() in /sitefolder/functions.php on line 1096

line 1096 is the first line in the first code box

Ben · Accepted Answer · 2011-11-18 19:03:30Z

3

First, never use array keys without checking that they exist. Wrap you code in

if (array_key_exists('image', $_FILES)) 
{
  // ...
} 
else 
{
  // error handling
}

Second, even if the key exists, $_FILES['image']['name'] is supposed to be a string, you cannot feed this to foreach anyway. Better:

foreach ($_FILES as $file) 
{     
  $uploadfile = $uploaddir . basename($file['name']);
  if (!move_uploaded_file($file["tmp_name"], $uploadfile)) 
  {
      echo set_e('error','Image ['.$i.'] not uploaded','');
  }
}

edited Nov 18, 2011 at 19:03

Ben

7028 silver badges25 bronze badges

answered Nov 18, 2011 at 18:21

Tomalak

339k68 gold badges547 silver badges635 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Ben Over a year ago

Hi tried original code, and tried it with the edit i added and it still doesnt work

Tomalak Over a year ago

@Ben: Can you explain what "doesn't work" means? A print_r() of $_FILES might also give some insight.

Ben Over a year ago

I mean it display the error message set_e(...). Also the print_r is returning empty ... Array()

Eduardo Reveles Over a year ago

Did you have the enctype="multipart/form-data" on the <form> tag?

Ben Over a year ago

I added it in after seeing the array was empty. Also change the form input elements from being an array. They're uploading now, just having to mess with the code moving it from the tmp folder. Thanks for the help

Collectives™ on Stack Overflow

multiple file upload foreach error

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related