PHP random image number not consistant

Question

I'm using a PHP script which gets data from a text file and displays three random images in a php page. The problem I'm having is that three images don't always show on the page :/ When refreshing the page to see the new random images, sometimes only 1 image will display, sometimes only 2, and then sometimes three. I want three random images to display always. Does anyone have any ideas what I could add to make sure three images always display? :S

php:

 <?php 
 $random = "random.txt";
$fp = file($random);
shuffle($fp);
$keys = array_rand($fp, 3);
for ($i = 0; $i < 3; $i++):
$rl = $fp[$keys[$i]]; 
echo $rl;
endfor;
?>

html:

 <div class="imagecontainer">
 <?php include('rotate.php') ?>
 </div>

Is there any logic to when the images get displayed and when not? i.e. are certain images never displayed? Have you looked at the HTML source when one or more of the images aren't displayed to see if anything's wrong there? ps you might find it easier to use foreach() rather than for() in a situation like this. — liquorvicar
– liquorvicar, Commented Nov 28, 2011 at 8:39
I just want each of the three random images be different - so there are no duplicate random images shown at once. I checked out the html source when only 1/2 images are shown, and it just shows that only one/two images are printed :( — Moozoo
– Moozoo, Commented Nov 28, 2011 at 8:52
Have you examined the contents of the $fp array? Is it possible that there are blank lines in there? — liquorvicar
– liquorvicar, Commented Nov 28, 2011 at 9:26
Ahh yes there was a blank line ><;; Thank you, it works fine now! :) — Moozoo
– Moozoo, Commented Nov 29, 2011 at 19:04

TRD · Accepted Answer · 2011-11-28 09:29:35Z

3

array_rand() serves the keys (and values) of your file-array but does NOT re-index them zero-based. Let's say your array has 5 elements, 0 to 4. Then getting random keys can result in an array containing (0 => "img0", 2 => "img2", 4 => "img4").

Your loop only cares for the index with number 0 to 2. That's why in some cases you are missing some of your images.

Try using for_each to loop through your $keys-array. This should ignore the index numbers of your array.

answered Nov 28, 2011 at 9:29

TRD

1,02711 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP random image number not consistant

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related