Argument 2 passed to PHPUnit_Framework_ExpectationFailedException::__construct() must be an instance of PHPUnit_Framework_ComparisonFailure

Question

I get this error when I run phpunit with selenium.

When I check the class PHPUnit_Framework_ExpectationFailedException, I found the following line :

public function __construct($message, PHPUnit_Framework_ComparisonFailure $comparisonFailure = NULL)

Indeed, the second parameter has to be an object and not a string but if I check the class SeleniumTestCase, I can see :

    if ($e instanceof PHPUnit_Framework_ExpectationFailedException) {
        if (is_object($e->getComparisonFailure())) {
            $message = $e->getComparisonFailure()->toString();
        } else {
            $message = $e->getMessage();
        }

        $buffer .= "\n" . $message;

        throw new PHPUnit_Framework_ExpectationFailedException($buffer, $message);

The $message seems to be a string and not an object.

Can you help me ?

PS: I am using the version of phpunit (3.6.4) and the last version of selenium (1.1.1)

David Harkness · Accepted Answer · 2011-11-30 18:28:53Z

1

In PHPUnit 3.6 PHPUnit_Framework_ExpectationFailedException was changed by removing the second optional custom message. It looks like phpunit-selenium hasn't been updated with this change yet. You can downgrade to PHPUnit 3.5.x in the meantime or fix it and submit a pull request.

answered Nov 30, 2011 at 18:28

David Harkness

36.6k11 gold badges119 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

giorgiosironi · Accepted Answer · 2011-12-01 15:23:54Z

0

The bug has been fixed in the master branch and will be rolled out in the release after 1.1.1. https://github.com/sebastianbergmann/phpunit-selenium/issues/78

answered Dec 1, 2011 at 15:23

giorgiosironi

1,1041 gold badge11 silver badges18 bronze badges

Collectives™ on Stack Overflow

Argument 2 passed to PHPUnit_Framework_ExpectationFailedException::__construct() must be an instance of PHPUnit_Framework_ComparisonFailure

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related