Linked List output crash

Question

My program hangs when outputting contents of my linked list. I can't change the header, only the cpp file.

playlist.h:

class PlayList {
    private:

    struct SongNode {
        Song data;
        SongNode* next;
        SongNode (const Song& s, SongNode* nxt = 0)
          : data(s), next(nxt)
        {}
    };

    friend std::ostream& operator<< (std::ostream& out, const PlayList& s);

    SongNode* first; // head of a list of songs, ordered by title, then artist
    //Snip...

    inline
    std::ostream& operator<< (std::ostream& out, const PlayList& pl)
    {
        for (PlayList::SongNode* current = pl.first; current != 0; current = current->next)
            out << current->data << std::endl;
        return out;
    }

playlist.cpp

using namespace std;



PlayList::PlayList()
    : totalTime(0,0,0)
{
}


void PlayList::operator+= (const Song& song)
{
    SongNode* newNode = new SongNode(song, first);
    first = newNode;
}

When outputting the list all of the data that is supposed to print, does print, but then the program hangs.

Anthony · Accepted Answer · 2011-12-02 00:37:43Z

6

In the constructor of class PlayList, you need to initialise first:

public:
    PlayList() : first(NULL) {}

Otherwise, in your operator<<, you reach the end of the list and instead of encountering NULL, you just get a junk pointer.

answered Dec 2, 2011 at 0:37

Anthony

12.5k10 gold badges72 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ben Jackson · Accepted Answer · 2011-12-02 00:33:35Z

4

You forgot to initialize first in the constructor.

answered Dec 2, 2011 at 0:33

Ben Jackson

94.6k9 gold badges103 silver badges154 bronze badges

Collectives™ on Stack Overflow

Linked List output crash

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related