MySQL error: ' You have an error in your SQL syntax'

Question

This code below gives me this error:

"You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''' where id = '000'' at line 1"

I don't understand the issue here

<?php
include(".conf.php");
$con = mysql_connect($conf['db_hostname'], $conf['db_username'], $conf['db_password']) or die (mysql_error());
$db = mysql_select_db("aTable", $con);
$pr = $_GET['aThing'];
$pr = addslashes(htmlentities($prof));
$info_array = mysql_query("SELECT * FROM '$db' where id = '$pr'", $con) or die(mysql_error()); 

while($row = mysql_fetch_array( $info_array )) {
    echo $row['aThing'];
    echo "</br>";
    echo $row['aThing'];
    echo "</br>";
    echo $row['aThing'];
    echo "</br>";
    echo $row['aThing'];
};
?>

Thanks for your help.

a1ex07 · Accepted Answer · 2011-12-13 23:27:16Z

3

You should put table name into FROM : SELECT * FROM aTable WHERE .....Also, you don't escape variable that comes from user. You will need something like :
mysql_query("SELECT * FROM aTable where id = '".mysql_real_escape_string($pr)."'", $con) or die(mysql_error());

answered Dec 13, 2011 at 23:27

a1ex07

37.4k12 gold badges93 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Joe Torraca Over a year ago

Ok that got rid of the error but now it says No database selected

Nonym Over a year ago

@JosephTorraca, remember this line?: $db = mysql_select_db("aTable", $con); ? change the value "aTable" to the name of the database you need to access, where aTable is from...

Nonym · Accepted Answer · 2011-12-13 23:26:07Z

2

Function mysql_select_db returns either TRUE or FALSE

Instead, try:

$info_array = mysql_query("SELECT * FROM aTable where id = '$pr'", $con) or die(mysql_error());

Or perhaps:

$dbtable = "aTable";
$info_array = mysql_query("SELECT * FROM $dbtable where id = '$pr'", $con) or die(mysql_error());

answered Dec 13, 2011 at 23:26

Nonym

6,2971 gold badge28 silver badges21 bronze badges

Comments

duffymo · Accepted Answer · 2011-12-13 23:28:19Z

2

I am pretty sure it doesn't have any errors with the exception of the fatal error killing it.

I would say you'll get to a solution faster if you believe MySQL when it tells you there's a problem.

Re-reading the error message:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''' where id = '000'' at line 1

I would question the table name and the quotes around the id. If that's an integer column, I'd expect to see a number without quotes.

answered Dec 13, 2011 at 23:28

duffymo

310k46 gold badges376 silver badges570 bronze badges

Comments

Christian Specht · Accepted Answer · 2011-12-13 23:30:49Z

1

If I remember correctly, mysql_select_db returns true or false. It doesn't return database name.

edited Dec 13, 2011 at 23:30

Christian Specht

36.6k16 gold badges132 silver badges190 bronze badges

answered Dec 13, 2011 at 23:28

Odobenus Rosmarus

6,0082 gold badges21 silver badges23 bronze badges

Collectives™ on Stack Overflow

MySQL error: ' You have an error in your SQL syntax'

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related