Object Array For Loop

Question

public class Team {
    public int health;
    public int x;
    public int conflict;

}

public class Test extends Activity {
    Team enemy[] = new Team[50];
        public void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);

            for(int i =0; i<enemy.length; i++){
            enemy[i].health = 0;
            enemy[i].x = -100;
            enemy[i].conflict = 0;
            }
        }
}

With the for loop my game crashes, without the for loop it run. What am I doing wrong? thanks for the help ahead of time!

-1 because some very simple debugging would have solved this one. — Emil Lundberg
– Emil Lundberg, Commented Dec 22, 2011 at 20:31

Ted Hopp · Accepted Answer · 2011-12-22 20:24:43Z

7

When you create the array:

Team enemy[] = new Team[50];

all the entries are null. You need to initialize each element of the array in your loop:

for(int i =0; i<enemy.length; i++){
    enemy[i] = new Team(); // <-- added
    enemy[i].health = 0;
    enemy[i].x = -100;
    enemy[i].conflict = 0;
}

answered Dec 22, 2011 at 20:24

Ted Hopp

235k48 gold badges412 silver badges533 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

GETah · Accepted Answer · 2011-12-22 20:24:56Z

0

You forgot to instantiate enemy[i]

Do the following instead

Team enemy[] = new Team[50];
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    for(int i =0; i<enemy.length; i++){
      enemy[i] = new Team();
      enemy[i].health = 0;
      enemy[i].x = -100;
      enemy[i].conflict = 0;
    }
}

answered Dec 22, 2011 at 20:24

GETah

21.5k7 gold badges67 silver badges110 bronze badges

Comments

Danny · Accepted Answer · 2011-12-22 20:25:49Z

0

You need to create a new Team object each iteration of the loop

for(int i =0; i<enemy.length; i++){
        enemy[i] = new Team();
        enemy[i].health = 0;
        enemy[i].x = -100;
        enemy[i].conflict = 0;
        }

answered Dec 22, 2011 at 20:25

Danny

7,5379 gold badges49 silver badges71 bronze badges

Comments

aeoliant · Accepted Answer · 2011-12-22 20:26:02Z

0

you never initialized the elements of enemy.

enemy[i] = new Team();

enemy[i].health = 0;
enemy[i].x = -100;
enemy[i].conflict = 0;

answered Dec 22, 2011 at 20:26

aeoliant

3872 silver badges10 bronze badges

Collectives™ on Stack Overflow

Object Array For Loop

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related