missing ) after argument list (line 1) in javascript

Question

I keep getting a "missing ) after argument list" (on line 1) when debugging my javascript with firebug. I don't know what is wrong as it seems all parentheses are there.

The function is supposed to place an image that can be clicked to open a lightbox in the div with id "bigPic".

Here's the relevant code:

<script type="text/javascript">
function addContent(divId,filePath,comment) {
document.getElementById(divId).innerHTML = "<div align=\"center\"><a href="+filePath+" title="+comment+" rel=\"lightbox\"><img src="+filePath+" alt="+comment+" style=\"max-height:270px;max-width:410px;\"/></a></div><div id="+comment+" align=\"center\"  style=\"font-family:Verdana;margin-top:-13px;color:white;background-color:#07396B;\"><p>"+comment+"</p></div>&nbsp;";
}
</script>
...
<div width="420px" height="320px" id="bigPic" name="bigPic">
<img src="http://www.villa-gloria-katouna.com/Pool%20viewsmall.JPG" />
</div>
...
echo "<div align=\"center\" style=\"display:inline; overflow:hidden;\"><img src=\"pics/$file\" style=\"cursor:pointer;cursor:hand;\" alt=\"$file\" height=\"30px\" width=\"30px\" onclick=\"addContent('bigPic', $file, $comment);\"/></a></div>&nbsp;";

That code is fine. Your error is somewhere else. Show your full code. — Alex Turpin
– Alex Turpin, Commented Dec 26, 2011 at 22:20
@Zirak as in, there are no bugs in it. But I might have been wrong, Pointy caught something I hadn't noticed. — Alex Turpin
– Alex Turpin, Commented Dec 26, 2011 at 22:23

Pointy · Accepted Answer · 2011-12-26 22:21:49Z

3

I think you forgot quote characters around "$file" and "$comment" in the "onclick" handler code.

     ... onclick=\"addContent('bigPic', '$file', '$comment');\" ...

I don't know PHP so that may or may not be the way to get quotes in the "onclick" string, but they need to be there. Otherwise if the comment is "hello world" that'll expand to

     ... onclick="addContent('bigPic', whatever-$file-is, hello world)" ...

which is clearly incorrect.

answered Dec 26, 2011 at 22:21

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mats Raemen Over a year ago

echo "<div align=\"center\" style=\"display:inline; overflow:hidden;\"><img src=\"pics/" . $file . "\" style=\"cursor:pointer;cursor:hand;\" alt=\"" . $file . "\" height=\"30px\" width=\"30px\" onclick=\"addContent('bigPic', 'pics/" . $file . "', '" . $comment . "');\"/></a></div> "; did the trick, thx!

Tom van der Woerdt · Accepted Answer · 2011-12-27 14:35:53Z

1

try

onclick=\"addContent('bigPic', '$file', '$comment');\"

instead of

onclick=\"addContent('bigPic', $file, $comment);\"

edited Dec 27, 2011 at 14:35

Tom van der Woerdt

30k7 gold badges76 silver badges105 bronze badges

answered Dec 26, 2011 at 22:26

darlinton

2,13116 silver badges21 bronze badges

Comments

abuduba · Accepted Answer · 2011-12-26 22:38:27Z

0

Single quotes as wrapper of string istead double prevent to writing backslashes. This faciliate now and in the future:)

'<div align="center">'

answered Dec 26, 2011 at 22:38

abuduba

5,0637 gold badges29 silver badges43 bronze badges

Comments

Virendra · Accepted Answer · 2011-12-26 23:33:51Z

0

Change your script code as:

<script type="text/javascript">
function addContent(divId,filePath,comment) {
document.getElementById(divId).innerHTML = "<div align=\"center\"><a href=\"" + filePath + "\" title=\"" + comment + "\" rel=\"lightbox\"><img src=\"" + filePath + "\" alt=\"" + comment + "\" style=\"max-height:270px;max-width:410px;\"/></a></div><div id=\"" + comment + "\" align=\"center\"  style=\"font-family:Verdana;margin-top:-13px;color:white;background-color:#07396B;\"><p>\"" + comment + "\"</p></div>&nbsp;";
}
</script>

Also change your echo to

echo "<div align=\"center\" style=\"display:inline; overflow:hidden;\"><img src=\"pics/" . $file . "\" style=\"cursor:pointer;cursor:hand;\" alt=\"" . $file . "\" height=\"30px\" width=\"30px\" onclick=\"addContent('bigPic', '" . $file . "', '" . $comment . "');\"/></a></div>&nbsp;";

edited Dec 26, 2011 at 23:33

answered Dec 26, 2011 at 22:24

Virendra

2,5433 gold badges23 silver badges39 bronze badges

1 Comment

Mats Raemen Over a year ago

this still gives me the same errors, I will post my full code

Collectives™ on Stack Overflow

missing ) after argument list (line 1) in javascript

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related