Problem with KeyPress Javascript function

Question

I call a javascript function from a textbox by using OnKeyPress="clickSearchButton()"

Here is my function:

function clickSearchButton()
{
  var code = e.keyCode || e.which;
  var btnSearch = document.getElementById("TopSubBanner1_SearchSite1_btnSearchSite");
  if(code == 13);
      {          
           btnSearch.click(); 
           return false; 
      } 
}

My problem is that this function fires when the user hits the enter button in any textbox, not just the one that calls the function. What am I missing?

EDIT: Still not working correctly. So I'll throw my HTML out there if that helps.

<input name="TopSubBanner1:SearchSite1:txtSearch" type="text" id="TopSubBanner1_SearchSite1_txtSearch" OnKeyPress="clickSearchButton(this)" /><input type="submit" name="TopSubBanner1:SearchSite1:btnSearchSite" value="Search" id="TopSubBanner1_SearchSite1_btnSearchSite" />

Also, this is an ASP.NET page if that makes a difference.

How are you connecting your clickSearchButton function to the OnKeyPress event? — RichieHindle
– RichieHindle, Commented May 15, 2009 at 16:36
You should change the title of this to not be so vague. At least mention the keypress event. — Josh Stodola
– Josh Stodola, Commented May 15, 2009 at 17:19

TJ L · Accepted Answer · 2009-05-15 17:45:10Z

6

The event is by default passed as an argument to your function, but your not capturing it as a parameter. If you capture it, the above should work correctly.

function clickSearchButton(e)
{
   e = e || window.event //for IE compliane (thanks J-P)
   //etc

or

function clickSearchButton()
{
   var e = arguments[0];
   e = e || window.event;

Also you have an extra semicolon as Kevin pointed out.

edited May 15, 2009 at 17:45

answered May 15, 2009 at 16:44

TJ L

24.5k7 gold badges63 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Gumbo Over a year ago

Alternatively arguments[0].

James Over a year ago

Also, you'll want it to work in IE. So e = e || window.event;

kemiller2002 · Accepted Answer · 2009-05-15 18:32:49Z

4

function clickSearchButton(e)
{
  var code;

if(window.event)
    code = e.keyCode;
else
   code = e.which;

var btnSearch = document.getElementById("TopSubBanner1_SearchSite1_btnSearchSite");
  if(code == 13)
      {          
           btnSearch.click(); 
           return false; 
      } 
}

and your calling method should be:

onkeypress="clickSearchButton(event)"

edited May 15, 2009 at 18:32

answered May 15, 2009 at 16:37

kemiller2002

116k28 gold badges201 silver badges255 bronze badges

Collectives™ on Stack Overflow

Problem with KeyPress Javascript function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related