Creating multiple variables with loop?

Question

I am wondering if there is an elegant way to create variables using a loop in ruby?

Say I want to put this in some sort of loop

def workhours
  @monday = blah
  @tuesday = brah
  @wednesday = bro
  @thursday = blap
  @friday = blagh
end

What I want to be able to do

def workhour_ideally
  days = [ "monday", "tuesday", "wednesday", "thursday", "friday" ]

  days.each do |smack|
    @"smack" = whatever
  end
end

Is this possible with ruby?

tadman · Accepted Answer · 2012-01-04 20:55:59Z

5

Yes it's possible with Rails. No you shouldn't do it. If I had to guess, I'd say this is a PHPism of some kind.

What's better is to use a Hash:

@days = {
  :monday => blah,
  :tuesday => brah,
  # ...
  :friday => blagh
}

Then you can iterate over these as you wish. Referencing one of them is only slightly more typing: @days[:monday] instead of @monday.

Using a proper data structure allows you to manipulate it, iterate over it, and offers all kinds of opportunities to test it thoroughly.

answered Jan 4, 2012 at 20:55

tadman

212k23 gold badges237 silver badges266 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andrew Grimm · Accepted Answer · 2012-01-04 21:53:17Z

2

Yes, it's possible. I think it's called instance_variable_set and it'd be safer doing that than using the evil eval .

But use a hash instead if practical.

answered Jan 4, 2012 at 21:53

Andrew Grimm

82.3k58 gold badges210 silver badges355 bronze badges