C# Method Overflow

Question

private void btnMiles_Click(object sender, EventArgs e)
{
    try
    {
        int milesless200 = int.Parse(txtMiles.Text);
        int milesmore200 = int.Parse(txtMiles200.Text);

        MilesCal workingoutmilescost = new MilesCal();
        if (milesless200 > 200)
        {
            lblMilesMorethan200.Text = "You can't enter more then 200 in the first box";
        }
        else
        {
            if (milesmore200 == 0)
            {
                 int carry = workingoutmilescost.MilesRepay(milesless200);
                 lblMilesShow.Text = carry.ToString();

            }
            else
            {
                int carry = workingoutmilescost.MilesRepay(milesless200, milesmore200);
                lblMilesShow.Text = carry.ToString();
            }
        }
        lblMilesError.Text = "No Error";
    }
    catch (FormatException fEx)
    {
        lblMilesError.Text = fEx.Message;
    }
}

My Defined class of MilesCal

 class MilesCal
    {
        public int MilesRepay(int a)
        {
            int x;
            return x = (a*5)/100;
        }
        public int MilesRepay(int a, int b)
        {
            int y;
            return y = (a*5)/100 + (b*2)/100;
        }
    }

This code is suppose to display in a label the cost a driver gets back from their driving at 5p for the first 200 miles then 2p after that. I have got the code working but then discovered that it has to be done using Method overflow. at the minute am getting an error Error 1 Cannot convert method group 'ToString' to non-delegate type 'string'. Did you intend to invoke the method? at

lblMilesShow.Text = carry.ToString;

Added the ().

Now the catch seems to be trippping, can i ask you guys again to work this out because its probably a simple fix again?

The ToString is not a property its a method hence should be ToString(); You are missing the opening and closing braces. — Rajesh
– Rajesh, Commented Jan 9, 2012 at 17:18
Darn. I clicked on this question thinking I was going to learn about some programming concept that I'd never heard of before. — ean5533
– ean5533, Commented Jan 9, 2012 at 17:20
@Dan1676, did you edit the question wit the "catch seems to be trippping[sic]" part? You're going to have to add more details, because I for one have no idea what that means. Better yet, ask a new question, since people have already answered for your first problem. — Ray
– Ray, Commented Jan 9, 2012 at 17:37

rekire · Accepted Answer · 2012-01-09 17:17:39Z

4

Try to add brackets

lblMilesShow.Text = carry.ToString();

answered Jan 9, 2012 at 17:17

rekire

48.1k34 gold badges184 silver badges279 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Roy Dictus · Accepted Answer · 2012-01-09 17:17:50Z

2

You need to use carry.ToString(), including the parentheses.

answered Jan 9, 2012 at 17:17

Roy Dictus

33.3k9 gold badges64 silver badges77 bronze badges

Comments

Bartosz Wójtowicz · Accepted Answer · 2012-01-09 17:18:13Z

2

ToString is a method. You need to use brackets. Try carry.ToString();

answered Jan 9, 2012 at 17:18

Bartosz Wójtowicz

1,40111 silver badges18 bronze badges

Comments

J. Holmes · Accepted Answer · 2012-01-09 17:23:37Z

2

The other answers are all right. .ToString is a method. So using the name of the method without invoking it means you are passing a reference to the method group, not doing the work of the method itself.

carry.ToString is a reference to the function ToString

carry.ToString() invokes the ToString method on the instance carry.

But, really, I think you are going about this all wrong, instead of having two text boxes you should just have the person enter the number of miles they drove. And then have a function that does this work for you:

    public int MilesRepay(int miles)
    {
        return Math.Min(200, miles) * 0.05 + Math.Max(0, miles-200) * 0.02;
    }

Or something like that....

answered Jan 9, 2012 at 17:23

J. Holmes

18.6k5 gold badges49 silver badges52 bronze badges

1 Comment

J. Holmes Over a year ago

oh... its homework. that or you have the worst employer ever.

Massimiliano Peluso · Accepted Answer · 2012-01-09 17:18:45Z

1

lblMilesShow.Text = carry.ToString();

answered Jan 9, 2012 at 17:18

Massimiliano Peluso

26.8k6 gold badges65 silver badges75 bronze badges

Comments

Jason · Accepted Answer · 2012-01-09 17:19:27Z

1

ToString is a method. You need to add parentheses after the name of the method.

lblMilesShow.Text = carry.ToString();

answered Jan 9, 2012 at 17:19

Jason

89.5k15 gold badges137 silver badges151 bronze badges

Comments

NominSim · Accepted Answer · 2012-01-09 17:19:33Z

1

ToString is not a property, but a method, invoke with brackets

lblMilesShow.Text = carry.ToString();

answered Jan 9, 2012 at 17:19

NominSim

8,5313 gold badges32 silver badges38 bronze badges

Comments

Michael Banzon · Accepted Answer · 2012-01-09 17:29:25Z

1

I assume that by

the catch seems to be tripping

you mean that you catch the exception in the catch-block in the bottom. If this is the case you I assume it can only be a parse exception from one of the int.Parse-calls. You are trying to parse something that is not an int - maybe an empty string??

answered Jan 9, 2012 at 17:29

Michael Banzon

4,9651 gold badge29 silver badges28 bronze badges

Comments

Olivier Jacot-Descombes · Accepted Answer · 2012-04-07 15:30:38Z

1

As others have already reported, you have to use parentheses.

The explanation of the error message "Cannot convert method group 'ToString' to non-delegate type" is, that a method name without parentheses designates the method itself and interprets it as a delegate. It does not call the method. If you want to call the method and use its return value, always use the parentheses!

You can think of a delegate as being the memory address of a method. (In reality, it is an object, which encapsulates this address.)

edited Apr 7, 2012 at 15:30

answered Jan 9, 2012 at 17:27

Olivier Jacot-Descombes

114k14 gold badges149 silver badges202 bronze badges

Collectives™ on Stack Overflow

C# Method Overflow

9 Answers 9

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

9 Answers 9

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related