manipulate array by jQuery

Question

I have the loop below:

        var myArray = [];
        $(this).children('a').each(function () {
            myArray.push($(this).attr('href'));
        });

which fires 3 times. When I look inside that array, I see that there is only one (last added) item. Why ?

What is this code inside of? If you're inside another function or loop, you're resetting the myArray each time you get to it. — MetalFrog
– MetalFrog, Commented Jan 16, 2012 at 18:31

Rob W · Accepted Answer · 2012-01-16 18:32:14Z

3

Because you use declare myArray as a local variable. If you want the array's values to persist, move var myArray = []; outside the common function.

var myArray = []; // This variable is shared by all instances of somefunction
$('#example').click(function() {
    $(this).children('a').each(function () {
        myArray.push($(this).attr('href'));  //myArray in the parent scope
    });
});

answered Jan 16, 2012 at 18:32

Rob W

350k87 gold badges811 silver badges683 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

gdoron Over a year ago

it's declared outside the jquery function, so i don't think this it the problem. + it does has one value...

Rob W Over a year ago

@gdoron I don't see all of the code. It's perfectly possible that the OP invokes the function using .click().click().click() = 3 triggers. Still, if var myArray = []; is inside the click event handler, the array will only be locally available.

Adaz · Accepted Answer · 2012-01-16 18:38:20Z

1

I'd suggest using for loops as they are much faster.

http://jsperf.com/jquery-each-vs-for-loop/44

Try this:

var myArray = [],
    links = $("a.link");
for (var i = 0, l = links .length; i < l; i++) {
    myArray.push($(links[i]).attr("href"));
}
console.log(myArray);

answered Jan 16, 2012 at 18:38

Adaz

1,66512 silver badges14 bronze badges

Collectives™ on Stack Overflow

manipulate array by jQuery

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related