jQuery if only 1 item inArray

Question

Ok, so I have this jquery function to that grabs the checkbox's value and uses as identifier to show or hide an ul

The problem is that I couldn't manage to add an if only 1 choice in checkbox add X.

Here is the code and what I have tried

$('#filter li input:checkbox').change(
    function(){
        var show = $('input:checkbox:checked').map(function(){
           return $(this).val();
        });
        if (show.length > 0)
        {
                $('#list li').each(
                function(){
                    /*if ($.inArray($(this).attr('class'),show) <= 1)
                    {
                        console.log($(this));
                    }
                    else */if ($.inArray($(this).attr('class'),show) > -1)
                    {                        
                        $(this).show();
                    }
                    else
                    {
                        $(this).hide();
                    }
                });
        }
        else {
            $('#list li').show();
        }
    });

I don't really understand how this works: if ($.inArray($(this).attr('class'),show) > -1) because I have tried if ($.inArray($(this).attr('class'),show) = 1) and nothing

Mutation Person · Accepted Answer · 2012-01-17 12:17:45Z

2

You're assigning a value in the if clause:

if ($.inArray($(this).attr('class'),show) = 1)

To break it down, what this is actually saying is equivalent to

$.inArray($(this).attr('class'),show) = 1;
if ($.inArray($(this).attr('class'),show))
{
    ...

You should use the == comparison operator

if ($.inArray($(this).attr('class'),show) == 1)

Or, more correctly avoiding type coersion, use ===

if ($.inArray($(this).attr('class'),show) === 1)

This will avoid comparison between 1 and "1" returning true

edited Jan 17, 2012 at 12:17

answered Jan 17, 2012 at 12:12

Mutation Person

30.6k18 gold badges102 silver badges166 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Alex Over a year ago

sorry, I should've removed that before posting... it is not the case... I need to fix the if inside $('#list li').each(...

Mutation Person Over a year ago

Errrr, well, same applies. Use the === instead. if ($.inArray($(this).attr('class'),show) === 1)

Alex Over a year ago

for some reason it doesn't work. I have tried if ($.inArray($(this).attr('class'),show) == 1) and also === 1 and the alert that I added doesn't popup

Mutation Person Over a year ago

Well, what is the value of the thing you are checking. I.e. do alert($.inArray($(this).attr('class'),show) ) and see what you get. If it is equal to 0,2,3,4, etc then the condition will not be met.

Collectives™ on Stack Overflow

jQuery if only 1 item inArray

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related