Saving multiple records in a Database with Hibernate

Question

I want to save multiple records in DB using Hibernate.I m succeeded in that.But thinking my approach is wrong.Since If records increases it will create performance prob.

I want to store in DB like,

FirstName          LastName   
FNameABC           LNameCC         
FNamePQR           LNameDD         
FNameXYZ           LNameEE

I stored the above values in DB as,

Iterator itr = list.Iterator();
while(itr.hasNext()) {
   Test t = (Test)itr.next();
   dbEntity.setFirstName(t.setFirstName());
   dbEntity.setLastName(t.setLastName());
   session.beginTransaction();
   session.save(dbEntity);
   session.getTransaction().commit();
   session.close();
}

Here I'm saving the value in the seession inside a loop. So every time for each record it will call beginTransaction(), save(), commit(). Is there any better approach ?

are you sure every insert should be done in a separate transaction? — Wojciech Owczarczyk
– Wojciech Owczarczyk, Commented Jan 19, 2012 at 12:56

Goran Nastov · Accepted Answer · 2017-06-21 10:30:09Z

3

Please take a look at this page: http://docs.jboss.org/hibernate/core/3.3/reference/en/html/batch.html

You should open a transaction, save the entities (in the loop), at the end commit the transaction and close the session. As suggested you can have a counter while looping and flash/clean the session after certain number is reached - periodically.

edited Jun 21, 2017 at 10:30

answered Jan 19, 2012 at 13:00

Goran Nastov

9851 gold badge10 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Alex Barnes Over a year ago

Using this approach with large numbers of entities it will be necessary to flush and clear the session at regular intervals. Dirty checking a large number of entities quickly becomes a bottleneck.

Goran Nastov Over a year ago

Depends on the case, number of entities, number of open sessions ... Sometimes does not worth to implement complex solution if the cases won't happen. My answer was only for the specified situation. I agree that in extreme cases different approach should be considered.

JB Nizet · Accepted Answer · 2012-01-19 13:13:35Z

You don't choose to start and commit a transaction based on technical or performance considerations. You choose to do it based on what you consider should be done atomically, coherently, and in isolation to the other transactions. Read http://en.wikipedia.org/wiki/ACID.

If you want to make sure that all the inserts either succeed or fail, but that you shouldn't be in a state where half succeed and the other half fail, then your transaction should encapsulate all the inserts: you start the transaction before the first one, and commit it after the last one.

If, on the contrary, you want each insert to be done in its own transaction, and for example be able to catch the exception if one fails but coninue inserting the others, then each insert should be done in its own transaction, like you're doing.

Collectives™ on Stack Overflow

Saving multiple records in a Database with Hibernate

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related