Segmentation Fault in constructor

Question

In my TeamMatcher.C, I have the following bit of code:

void TeamMatcher::makeTeamSet(){                                                                                                          
  //Segmentation fault here:                                                                                                               
    Team tempTeam(rosterExcellent[0]);
  //...more code in this method below this point, but it has all been commented out.

rosterExcellent is a vector

Here is the constructor for Team(Student member1):

Team::Team (Student member1)
{
  // members is a vector<Student> instance variable in Team
  // commonHrsAvailable is a vector<int> in Team


  // members.push_back(member1);                                                                                                                                  
  //commonHrsAvailable = member1.hrsAvailable;                                                                                                                   
  //numberOfCommonHrsAvailable = commonHrsAvailable.size();                                                                                                       
}

Notice all the lines are commented out and I still get the segmentation fault. This is the last bit of code to be executed.

Now, I messed around changing members to vector, changing this constructor's parameter to a Student*, and the rosterExcellent to vector (as well as changing the . notation to -> where appropriate). I got it to the point where it would run the first line of the constructor (members.push_back(member1)), but it seg faulted on the next line (even after I changed to -> notation).

Is it possible that rosterExcellent is a null pointer or an empty vector? — Oliver Charlesworth
– Oliver Charlesworth, Commented Jan 19, 2012 at 17:23
What's in rosterExcellent? Is it instantiated and does an element exist at position 0? — devshorts
– devshorts, Commented Jan 19, 2012 at 17:23
OMGOIH@#ORIFHEOFHEIEFWH:!!! What a noob move! Thank you! runs away in shame Can close this as that was a pretty noob mistake! — user114518
– user114518, Commented Jan 19, 2012 at 17:24
Actually, I'd recommend against closing it. It will probably be helpful to others, but only if you can provide a little more detail as to the problem you discovered... was rosterExcellent indeed null or empty? — andand
– andand, Commented Jan 19, 2012 at 17:29

DaveShaw · Accepted Answer · 2012-01-19 23:14:10Z

1

rosterExcellent[0] is either NULL or not initialized properly.

edited Jan 19, 2012 at 23:14

DaveShaw

52.9k18 gold badges118 silver badges142 bronze badges

answered Jan 19, 2012 at 23:02

Foggzie

9,8511 gold badge33 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Segmentation Fault in constructor

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related