using jquery in a REGULAR javascript ...script?

Question

I am not really sure how to word the question, but I basically have an old javascript that checks file extensions of a user upload BEFORE it is sent to the server for processing. (Just for the admin section of a website.)

Well, I want a div to slideDown() whenever a javascript condition returns true inside a loop (meaning, the file is good to upload).

Code so far:

  var thisext = fieldvalue.substr(fieldvalue.lastIndexOf('.'));
for(var i = 0; i < extension.length; i++) {
    if(thisext == extension[i]) { return true;

            $("#pleasewait").slideDown();

         }
    }
alert("Please upload ONLY .mp3 files. No other files will work.");
return false;
}

You don't want to just rely on JavaScript to check for this. Someone could simply turn off their JavaScript, or override your function, or do whatever else they want with their client-side code, and upload a random file anyway. If you don't check for this in your server-side code, your app may blow up. — voithos
– voithos, Commented Jan 22, 2012 at 4:52
Why do you care if the files are named .mp3, or .mpeg3 or .mpeg2layer3 or .flubber? — sarnold
– sarnold, Commented Jan 22, 2012 at 4:55
@voithos I know. Agreed. But like I said, this is in a website password protected main admin section. And also, imagine hitting the upload button and then waiting 50 seconds only to see "Not valid file type." Thats why a javascript check FIRST and then the PHP check LATER is more user friendly. — PaulHanak
– PaulHanak, Commented Jan 22, 2012 at 19:56
@sarnold I care because the script that plays the music only uses .mp3 files, and that is it. — PaulHanak
– PaulHanak, Commented Jan 22, 2012 at 19:57
@PaulHanak: Most definitely; client-side for user-friendliness, and server-side for program correctness. — voithos
– voithos, Commented Jan 22, 2012 at 20:34

xdazz · Accepted Answer · 2012-01-22 04:53:13Z

5

You should put return true; after $("#pleasewait").slideDown();

answered Jan 22, 2012 at 4:53

xdazz

161k38 gold badges255 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mario J Vargas · Accepted Answer · 2012-01-22 05:02:03Z

3

The code has a textbook case of a logical error. The slidedown should occur before the return statement because the function will exit immediately after that line.

Try this within your function:

var thisext = fieldvalue.substr(fieldvalue.lastIndexOf('.'));
for(var i = 0; i < extension.length; i++) {
    if(thisext == extension[i]) { 
        $("#pleasewait").slideDown();

        return true;
     }
}

alert("Please upload ONLY .mp3 files. No other files will work.");
return false;

answered Jan 22, 2012 at 5:02

Mario J Vargas

1,1957 silver badges12 bronze badges

Collectives™ on Stack Overflow

using jquery in a REGULAR javascript ...script?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related