PHP array created through html form only stores last element

Question

I'm looping a question for the user with different numerical values for $i. They will input a quantity in the html form that is also looped. Upon them clicking submit, I would like to have an array (with the key ranging form [0] onwards) that stores their response to each particular variant of the question. However, with the code I have written, I only manage to store their last input with the key [0] as if it was the first element of the array. All the previous answers seem to be lost when I call print_r. Please, I would really appreciate it if anyone could point out why this is happening or how I could fix it.

<?php

    for ($i=2; $i<=10; $i++) 

    {
        print "question $i";

        echo"<form action=\"mysqlranked.php\" method=\"post\">
          <input type=\"text\" name=\"pools[]\" value=\"0\" maxlength=\"2\" size=\"2\">
          </form>
          <br>";
    }

    print "
    <form>
    <input type=\"submit\" name=\"formSubmit\" value=\"Submit\">
    </form>";

    if (isset($_POST["formSubmit"]))
    {
        $var = $_POST["pools"];
    }

    print_r($var);

?>

For the sake of everyone involved, can you please switch to using single quotes (apostrophes) so you can drop all those incessant escape slashes? — rockerest
– rockerest, Commented Jan 24, 2012 at 5:52
@rockerest even better, stop echo-ing HTML from PHP (see Moon's answer) — Phil
– Phil, Commented Jan 24, 2012 at 5:55
@Phil, I'd normally agree, but for this case it does seem a bit easier to use single quotes than to have to keep typing <?PHP ?> or even <? ?> — mowwwalker
– mowwwalker, Commented Jan 24, 2012 at 5:57

mowwwalker · Accepted Answer · 2012-01-24 05:50:28Z

1

You had each of your inputs in a new form and the submit button in its own form as well. I fixed it for you:

<?php

    echo "<form action=\"mysqlranked.php\" method=\"post\">";
    for ($i=2; $i<=10; $i++) 

    {
        print "question $i";

        echo"
          <input type=\"text\" name=\"pools[]\" value=\"0\" maxlength=\"2\" size=\"2\">

          <br>";
    }

    print "
    <input type=\"submit\" name=\"formSubmit\" value=\"Submit\">
    ";
    echo "</form>";
    if (isset($_POST["formSubmit"]))
    {
        $var = $_POST["pools"];
    }

    print_r($var);

?>

Let me know if it works.

answered Jan 24, 2012 at 5:50

mowwwalker

17.5k30 gold badges109 silver badges166 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Phil Over a year ago

You should check $_POST['pools'] before attempting to use it.

mowwwalker Over a year ago

@gf3, No problem. Also take into account the various suggestions floating around in the comments. Use single quotes when echoing html strings so you don't have to escape your double quotes, check the value of $_POST['pools'] before using it, and possibly use actual html instead of echoing strings.

Phil · Accepted Answer · 2012-01-24 05:57:01Z

1

You should not have a new form tag for every question.

Try the code below:

<form action="mysqlranked.php" method="post">

<?php
    for ($i = 2; $i <= 10; $i++)
    {
        print "question $i";
?>

    <input type="text" name="pools[]" value="0" maxlength="2" size="2">

<?php
    }
?>

    <input type="submit" name="formSubmit" value="Submit">
</form>

<?php
    if (isset($_POST["formSubmit"]))
    {
        $var = $_POST["pools"];
    }

    print_r($var);
?>

edited Jan 24, 2012 at 5:57

Phil

166k25 gold badges265 silver badges269 bronze badges

answered Jan 24, 2012 at 5:51

Moon

35.6k20 gold badges85 silver badges136 bronze badges

Comments

Pradeep Singh · Accepted Answer · 2012-01-24 05:56:15Z

0

    <?php

        for ($i=2; $i<=10; $i++) 

        {
            print "question $i";

            echo"<form action=\"mysqlranked.php\" method=\"post\">
              <input type=\"text\" name=\"pools[]\" value=\"0\" maxlength=\"2\" size=\"2\">

              <br>";
        }

        print "

        <input type=\"submit\" name=\"formSubmit\" value=\"Submit\">
        </form>";

     if (isset($_POST["formSubmit"])) 
        {

                for($counter=0;$counter<count($_POST["pools"]);$counter++)
                {
                    $var = $_POST['pools'][$counter]

                }

         }
print_r($var);

    ?>

edited Jan 24, 2012 at 5:56

answered Jan 24, 2012 at 5:51

Pradeep Singh

3,6323 gold badges33 silver badges42 bronze badges

Comments

krishna · Accepted Answer · 2012-01-24 06:10:42Z

0

you may use array_push($arrayName, $elementToBePushed);

answered Jan 24, 2012 at 6:10

krishna

9602 gold badges16 silver badges35 bronze badges

Collectives™ on Stack Overflow

PHP array created through html form only stores last element

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related