Symfony 2 Call a function in a Controller Method

Question

I have a method in a controller say like this. In fact, I'm in need to declare a function checkLogin so that I can use in several Controller method like below:

class DefaultController extends Controller
{
 /**
     * @Route("/test")
     * @Template()
     */
    public function testAction()
    {

        if (checkLogin()){}
            else {}
        exit;
    }

    public static function checkLogin()
    {
        return 1;
    }
}

In the above case, when I'm doing it like this, I'm getting the following error:

Fatal error: Call to undefined function NouPei\WebSiteBundle\Controller\checkLogin() in /home/noor/noupei/website/WebSiteBundle/Controller/DefaultController.php on line 142

That's bad software design. You should not place that in a controller. — i.am.michiel
– i.am.michiel, Commented Jan 24, 2012 at 13:41

meze · Accepted Answer · 2012-01-24 12:22:38Z

28

It's a method, not a function:

if (self::checkLogin()){}

answered Jan 24, 2012 at 12:22

meze

15.1k4 gold badges49 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chopchop · Accepted Answer · 2012-01-24 14:25:29Z

18

you can call the function like this :

$this->checkLogin();

answered Jan 24, 2012 at 14:25

Chopchop

2,95920 silver badges38 bronze badges

Comments

BlackCharly · Accepted Answer · 2012-01-24 12:06:43Z

5

For account management in Symfony 2, you should use the security management of symfony 2 (here). You will be able to check user login like this :

public function indexAction()
{
    // show different content to admin users
    if ($this->get('security.context')->isGranted('ADMIN')) {
        // Load admin content here
    }
    // load other regular content here
}

Source

If you don't want to use Symfony 2 security management, you should use services to make methods available for every controllers.

answered Jan 24, 2012 at 12:06

BlackCharly

6494 silver badges8 bronze badges

2 Comments

Noor Over a year ago

no forget about the login, I want to be able to call another function within a method

BlackCharly Over a year ago

You are allways able to call functions within a method... I don't understand what you mean

Francis · Accepted Answer · 2014-03-07 07:35:43Z

There are several ways to do this:

Use the firewall provided by Symfony. You can configure it in app/config/security.yml under the access_control: - { path: ^/anyurl-form/pattern$, role: ROLE_USER }

using this method: symfony will be the one to verify the validity of the session. and if the session is invalid, it will redirect the user automatically to login page and an unauthenticated user will never be able to visit these pages if not loggedin.

Implementing this method has several options too before it will work. You might need to create your own Provider or Use and existing one I recommend FOSUserBundle. This bundle has a variety on how to manage the user. Another option is creating your own Provider if you want to validate externally specially when you are using api's (SOA) to check the authenticity of the user.
If you want to add a method that will be used for all Controller. It's either you create a Class that extends Symfony's Controller:

class BaseController extends Controller { protected function checkLogin(){} }

class DefaultController extends BaseController { public function testAction() { $loggedIn = $this->checkLogin(); } }

Or you can create a trait and include it in your Controller.

trait ControllerTrait
{
   protected function checkLogin(){}
}

class DefaultController extends BaseController
{
      use ControllerTrait;

      public function testAction() 
      {
        $loggedIn = $this->checkLogin();
      }
}

But I highly recommend using the firewall for security purposes and it offers a lot of functionality and security checking.

Collectives™ on Stack Overflow

Symfony 2 Call a function in a Controller Method

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related