PHP error and JavaScript validation

Question

I have an error in my PHP on this line:

var strRooms = <?=$js_var?>;

It is saying that this has an invalid markup, what does this mean?

You can look at the application here: application

Now if you type in nothing in the textbox, then it doesn't display a message saying "Please Enter in a Room Number", if you type in a invalid room number then it doesn't show a message stating "This Room is Invalid". Why is it not working?

I know the code doesn't work in jsfiddle but I have included my code in the jsfiddle so that you can see the whole code and the way it is laid out. jsfiddle

So how can this error be fixed and how can the JavaScript validation message appear as they should do?

Niet the Dark Absol · Accepted Answer · 2012-01-25 00:42:51Z

3

var strRooms = <?php echo json_encode($js_var); ?>;

This will guarantee that it'll work, regardless of what type of variable $js_var is.

answered Jan 25, 2012 at 0:42

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user1163005 Over a year ago

That also works when getting rid of the error. Now the last problem is that why is it not showing a javascript validation message if textbox is empty or if wrong room number e.g. 42 is entered in a textbox. The validation message should appear after user has clicked on the prepare questions button. application url has been updated

Niet the Dark Absol Over a year ago

You keep reassigning $js_var = $data.",";. Try setting $js_var=Array(); before the loop, then $js_var[] = $data; inside your loop. Now, using my answer, you can get the array directly into JS, so you don't need to use .split(",");

user1163005 Over a year ago

so if I don't need var arrRooms = strRooms.split(','), then what do I call var arrRooms? does that become var arrRooms = '<?=$js_var?>';?

Niet the Dark Absol Over a year ago

Almost. You can move the strRooms and just use arrRooms = <?php echo json_encode($js_var); ?>;

user1163005 Over a year ago

Ok this is fine but I still have a problem with javascript validation not working properly. Do you know how to fix this. Validation does have to be in javascript btw, not php

Benny Tjia · Accepted Answer · 2012-01-25 00:44:03Z

2

Try this var strRooms ="<?php echo $js_var; ?>";

answered Jan 25, 2012 at 0:44

Benny Tjia

4,88310 gold badges42 silver badges49 bronze badges

5 Comments

user1163005 Over a year ago

I have upvoted this answer. The last problem is that why is it not showing a javascript validation message if textbox is empty or if wrong room number e.g. 42 is entered in a textbox. The validation message should appear after user has clicked on the prepare questions button. application url has been updated

Benny Tjia Over a year ago

@user1163005: Two things to check: 1. Make sure that something really gets returned to $js_var from server side. check your query, do a var dump. 2. do a console.log when you do a split string on strRooms. It probably does something weird when it tries to split using ',' and therefore when you try to match it with existing room data it doesnt match..

user1163005 Over a year ago

You are talking to a web programmer who isn't very experienced, can't we go step by step to make it easier for me to follow what I need to do?

Benny Tjia Over a year ago

First, when you grab $data from mysql query and as it happens, put var_dump($data) and check if it does return something you want. Second, you can try debug the javascript by using alert(strRooms) or console.log(strRooms), but for now just stick to using alert.. put that right underneath where you split the strRooms with ',' make sure that the code really goes through the conditional if block too on the javascript part.

user1163005 Over a year ago

Hi, I have updated my application which you can see if you click on 'application' on my question. I have alsp updated my jsfiddle so you can see current code. At bottom of my question I have wrote down the situation as it will be too big to put in comment

IsisCode · Accepted Answer · 2012-01-25 00:39:22Z

2

Have you tried quotes?

var strRooms = "<?=$js_var?>";

or

var strRooms = '<?=$js_var?>';

answered Jan 25, 2012 at 0:39

IsisCode

2,49018 silver badges20 bronze badges

1 Comment

user1163005 Over a year ago

That has got rid of the error thanks :). Now the last problem is that why is it not showing a javascript validation message if textbox is empty or if wrong room number e.g. 42 is entered in a textbox. The validation message should appear after user has clicked on the prepare questions button. application url has been updated

Chibuzo · Accepted Answer · 2012-01-25 00:50:16Z

0

Use this in case of empty textbox

var strRooms ="<?php echo !empty($js_var) ? $js_var : 'Error message'; ?>";

answered Jan 25, 2012 at 0:50

Chibuzo

6,1133 gold badges33 silver badges54 bronze badges

1 Comment

user1163005 Over a year ago

I want to use javascript to display message if textbox is empty to avoid page loading. If you look in jsfiddle in question then you can see my javascript validation, can't the javascript validation I have display the message?

Collectives™ on Stack Overflow

PHP error and JavaScript validation

4 Answers 4

5 Comments

5 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

5 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related