Calling Javascript Function in C# not working properly

Question

I wanna call a javascript function in c sharp code. i wanna hide the specific Li tag whose id is c sharp variable"li_name". For this i am calling a javascript function.

Cs Code:

  li_name = DSRolePermission.Tables[0].Rows[k]["MENUNAME"].ToString();
  StringBuilder script = new StringBuilder();

  script.Append("<script type=\"text/javascript\">");

  script.Append("li_visibility('" + li_name + "')");

  script.Append("</script>");

  Page.ClientScript.RegisterClientScriptBlock(typeof(object), "JavaScriptBlock", script.ToString());

JS code:

 <script type="text/javascript">
           function li_visibility('<%=li_name %>') {
document.getElementById('<%=li_name %>').style.display = 'hidden';

      }      
</script>

But this code is not working properly.

You are passing "li_name" in server inline side script to the li_visibility function in js.Then why are you again dynamically passing on the client end javscript function "li_visibility('<%=li_name %>')" like this? — sathishkumar
– sathishkumar, Commented Jan 25, 2012 at 8:14

jerjer · Accepted Answer · 2012-01-25 08:36:58Z

2

You should change your js-code to this:

<script type="text/javascript">
   function li_visibility(id) {
       document.getElementById(id).style.display = 'none';    
   }      
</script>

I you want to use hidden value, use the visibility property;

element.style.visibility = 'hidden'; //'visible' to show;

Note: When using visibility:hidden, the space occupied by the element is still present. display:none, will hide both the element and the occupied space.

edited Jan 25, 2012 at 8:36

answered Jan 25, 2012 at 7:59

jerjer

8,77634 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Devjosh Over a year ago

this would work just pass the li_name in javascript function from server side like Page.ClientScript.RegisterClientScriptBlock(typeof(object), "JavaScriptBlock","li_visibility("+li_name+")");

pallavisahane Over a year ago

this is also not working..:-(Is it necessary to change code of C sharp function.

Devjosh Over a year ago

also ensure that if your server event causing partial load of page then the case may be different. check for error's in firebug console

Devjosh Over a year ago

a little typo in the code in my comment please try this Page.ClientScript.RegisterClientScriptBlock(typeof(object), "JavaScriptBlock","<script>li_visibility("+li_name+")</script>");

user447356 Over a year ago

@pallavisahane if still not working please explain exactly what's wrong - you get error? Also, see my answer for something else you're missing.

user447356 · Accepted Answer · 2012-01-25 08:13:25Z

1

By having the same key, only the first call will be executed and the rest ignored silently.

Assuming you have this code in a loop, add the element ID to the JS key:

Page.ClientScript.RegisterClientScriptBlock(typeof(this), "JavaScriptBlock_" + li_name, script.ToString());

Also changed the type, it's better practice to pass the type of the calling page/control.

answered Jan 25, 2012 at 8:13

user447356

1 Comment

Devjosh Over a year ago

+1 for this extra information "Also changed the type, it's better practice to pass the type of the calling page/control."

Ashraf · Accepted Answer · 2012-01-25 07:59:24Z

0

Why you add a c# var inside the JS ? just update it to : <script type="text/javascript"> function li_visibility(x) { document.getElementById(x).style.display = 'hidden'; }</script>

answered Jan 25, 2012 at 7:59

Ashraf

2,6091 gold badge23 silver badges38 bronze badges

Comments

Dave Zych · Accepted Answer · 2012-11-13 04:24:22Z

0

<script type="text/javascript">
    function li_visibility('<%=li_name %>') 
    {
        document.getElementById('<%=li_name.ClientID %>').style.display = 'hidden';
    }      
</script>

This may help

edited Nov 13, 2012 at 4:24

Dave Zych

22k7 gold badges53 silver badges67 bronze badges

answered Jan 25, 2012 at 8:01

Madhu Beela

2,21516 silver badges16 bronze badges

Collectives™ on Stack Overflow

Calling Javascript Function in C# not working properly

4 Answers 4

5 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related