Displaying multiple results lines instead of one when using while loop

Question

Here is a summary of the behavior: while loop iterates to the end of the recordset, retrieves values. Values are then displayed in their respective places.

The issue is, I only want to display one set of values. Using while displays as many values as are records in the table being queried. Sample below:

What should display:

<div>
    <div>Service One is Stopped</div>
    <div>Service Two is Running</div>
    <div>Service Three is Stopped</div>
</div>

What actually happens:

<div>
    <div>Service One is </div> 
    <div>Service Two is Running</div>
    <div>Service Three is </div>
    <div>Service One is </div>
    <div>Service Two is </div>
    <div>Service Three is Running</div>
    <div>Service One is Stopped</div>
    <div>Service Two is </div>
    <div>Service Three is </div>
</div>

Below is the offending code. I apologize if this is a trivial question. I'm shaking off 2+ years of rust not writing code, and sometimes even the simple things get you :-). Many thanks for the assistance!!!

@using System.Configuration;
@using System.Data.SqlClient;
@using System.Data;
@using System.Linq;

@{
  System.Data.SqlClient.SqlConnection cn = null;
  cn = new System.Data.SqlClient.SqlConnection(ConfigurationManager.ConnectionStrings["sqlConn"].ToString());
  cn.Open();
  System.Data.SqlClient.SqlCommand cmd = new System.Data.SqlClient.SqlCommand("SELECT DISTINCT * FROM servicehealth", cn);
  var myreader = cmd.ExecuteReader();
}
@{
int rowCount = 0;
}
@while (myreader.Read())
{
        rowCount++;
        string service1status = "";
        string service2status = "";
        string service3status = "";
        string servicename = @myreader["servicename"].ToString();

        switch (servicename.ToLower())
        {
            case "serviceone":
                service1status = @myreader["servicestate"].ToString();
                break;
            case "servicetwo":
                service2status = @myreader["servicestate"].ToString();
                break;
            case "service3":
                service3status = @myreader["servicestate"].ToString();
                break;
        }

<div>
    <div>Service One is @service1status</div>
    <div>Service Two is @service2status</div>
    <div>Service Three is @service3status</div>
</div>
}

EDIT: Here's an abbreviated snapshot of the table in question:

ServiceId                   |  ServiceName  |   ServiceState  |  StartTrackTime  |  LastUpdated
1111-11111-111111-11111111  |  ServiceOne   |   Stopped       |  1/30/2012 0:00  |  1/30/2012 17:57
2222-22222-222222-22222222  |  ServiceTwo   |   Running       |  1/30/2012 0:00  |  1/30/2012 17:57
3333-33333-333333-33333333  |  ServiceThree |   Running       |  1/30/2012 0:00  |  1/30/2012 17:57

Having the servicehealth columns and data would help diagnose this. — Eric H
– Eric H, Commented Jan 31, 2012 at 5:03

GrantVS · Accepted Answer · 2012-01-31 05:20:11Z

2

Looks like you could just output the service and it's status during each iteration of the while and place it between the containing div tags. You should get one line for each service found.

<div>
@while (myreader.Read())
{
     string servicestatus = servicestatus = @myreader["servicestate"].ToString();
     string servicename = @myreader["servicename"].ToString();
    <div>@servicename is @servicestatus</div>

}
</div>

answered Jan 31, 2012 at 5:20

GrantVS

2,2511 gold badge25 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

lukiffer Over a year ago

+1 - much cleaner solution. Would just add a order by clause in the ... inline SQL...... :)

lukiffer · Accepted Answer · 2012-01-31 05:02:00Z

0

You need to move your string declarations and div tags outside of the while loop:

@{
int rowCount = 0;
string service1status = "";
string service2status = "";
string service3status = "";

while (myreader.Read())
{
    rowCount++;
    string servicename = @myreader["servicename"].ToString();
    switch (servicename.ToLower())
    {
        case "serviceone":
            service1status = @myreader["servicestate"].ToString();
            break;
        case "servicetwo":
            service2status = @myreader["servicestate"].ToString();
            break;
        case "service3":
            service3status = @myreader["servicestate"].ToString();
            break;
    }
}
}
<div>
    <div>Service One is @service1status</div>
    <div>Service Two is @service2status</div>
    <div>Service Three is @service3status</div>
</div>

answered Jan 31, 2012 at 5:02

lukiffer

11.4k9 gold badges48 silver badges71 bronze badges

3 Comments

mynameisneo Over a year ago

I thought so too - however, the servicestatus variables are not recognized once I do this

mynameisneo Over a year ago

Renders CS0103: The name 'service1status' does not exist in the current context

lukiffer Over a year ago

Updated to put the while loop in the same code block: @{ while() } instead of @while() as it is self contained scope.

Collectives™ on Stack Overflow

Displaying multiple results lines instead of one when using while loop

2 Answers 2

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related