UPDATE sql String Error

Question

been learning php for 3 weeks now and i find myself with a simple error that does not make sense:

I cant see what is wrong with this code.

Could someone please point me to why this is happening.

Its a simple insert and set sql query which is like this:

code:

$insertresults = "UPDATE usage SET message='".$message."',islive='".$islive."' WHERE id=1"; 
$insertresults_doit = mysql_query($insertresults) OR die(mysql_error());

the error i am getting is this:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'usage SET message='hello',islive='0' WHERE id=1' at line 1

as you can see, the variables are correct and to what i can see the sql string is correct also.

Thanks

Marc B · Accepted Answer · 2012-02-03 01:46:52Z

1

Your table name, usage, is actually a reserved word in MySQL. You'll have to quote it with backticks:

UPDATE `usage` SET ...

answered Feb 3, 2012 at 1:46

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Robert Over a year ago

this didnt change the error message :( as this is within a class, would this make a difference?

Robert Over a year ago

you was correct about using usage, i changed the table name and now it works. Thanks for that, i have been scratching my head for about 2 days now. :)

score 0 · Accepted Answer · 2012-02-03 00:40:25Z

0

$insertresults = "UPDATE usage SET message=$message,islive=$islive WHERE id=1"; 
$insertresults_doit = mysql_query($insertresults) OR die(mysql_error());

You don't need to wrap the variables the way you did, give this a try :) Taking a look at that error shows you the extra ' surrounding the column names - you don't want that.

edited Feb 3, 2012 at 0:40

answered Feb 3, 2012 at 0:30

user725913

5 Comments

user725913 Over a year ago

Don't wrap the variables at all then. Should work. If not, please give the new error. Thanks.

Nick Over a year ago

if the variables are INT then fine, but what if they are strings??

Nick Over a year ago

"UPDATE usage SET message='{$message}',islive='{$islive}' WHERE id=1"

Robert Over a year ago

@Nick i still get the exact same error if i use braces and even if i do not use the ' on int's the message is a message and the islive is either a 0 or a 1.

Nick Over a year ago

@Robert, have you made sure $message and $islive has been properly escaped? use: addslashes() or mysql_real_escape_string()

Stafford Williams · Accepted Answer · 2012-02-03 00:42:02Z

0

Try removing the quotes from $islive

answered Feb 3, 2012 at 0:42

Stafford Williams

9,8169 gold badges55 silver badges105 bronze badges

Comments

Shyju · Accepted Answer · 2012-02-03 00:45:05Z

0

Check whether you have a single quote in the variable values. It is always better to escape it before using in the sql statement

$message=addslashes($message);
$islive=addslashes($islive);

$insertresults = "UPDATE usage SET message='".$message."',islive='".$islive."' WHERE id=1"; 
$insertresults_doit = mysql_query($insertresults) OR die(mysql_error());

Assuming both the columns are of varchar type

answered Feb 3, 2012 at 0:45

Shyju

220k106 gold badges421 silver badges499 bronze badges

Comments

Nick · Accepted Answer · 2012-02-03 01:06:31Z

0

"UPDATE usage SET message='{$message}',islive='{$islive}' WHERE id=1" – Nick 21 mins ago

@Nick i still get the exact same error if i use braces and even if i do not use the ' on int's the message is a message and the islive is either a 0 or a 1. – Robert 6 mins ago

@Robert, have you made sure $message and $islive has been properly escaped? use: addslashes() or mysql_real_escape_string()

moved to answer (grew)

answered Feb 3, 2012 at 1:06

Nick

91613 silver badges30 bronze badges

1 Comment

Robert Over a year ago

yes just above this section the trim() htmlentities() and mysql_real_escape_string() are on these variables.

Collectives™ on Stack Overflow

UPDATE sql String Error

5 Answers 5

2 Comments

5 Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

5 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related