inserting javascript variable into html output of .innerHTML =

Question

I am trying to insert a variable passed to my function into the output of my .innerHTML = code but do not know how to properly insert it into the HTML output.

function playsong(song)
{
    parent.document.getElementById('player').innerHTML = '<object width="199" height="26"><param name="movie" value="audio_player_black.swf"><embed src="audio_player_black.swf?audio_file=upload/'[song]'&color=00000" width="199" height="26"></embed></object>';
}

I just get [song] in my HTML output rather than the value of [song]

Not sure how I need to do this properly

mkoryak · Accepted Answer · 2009-05-27 18:24:24Z

10

easy:

parent.document.getElementById('player').innerHTML = '<object width="199" height="26"><param name="movie" value="audio_player_black.swf"><embed src="audio_player_black.swf?audio_file=upload/'+song+'&color=00`000" width="199" height="26"></embed></object>';

just like concatenating any 2 + strings

answered May 27, 2009 at 18:24

mkoryak

58.1k64 gold badges204 silver badges262 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Diodeus - James MacFarlane · Accepted Answer · 2009-05-27 18:23:18Z

6

Instead of:

[song]

use:

 +song+

answered May 27, 2009 at 18:23

Diodeus - James MacFarlane

115k33 gold badges164 silver badges180 bronze badges

1 Comment

Chuck Over a year ago

You'll need to terminate the string beforehand and then reopen it afterward, too.

Conner · Accepted Answer · 2012-07-25 05:21:15Z

0

In place of [song] use +song+. It's a concatenate function that will add the value.

edited Jul 25, 2012 at 5:21

Conner

31.4k8 gold badges55 silver badges75 bronze badges

answered Feb 22, 2012 at 14:47

Kunal Vashist

2,4816 gold badges33 silver badges64 bronze badges

Collectives™ on Stack Overflow

inserting javascript variable into html output of .innerHTML =

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related