how to find the coding execution time in c#?

Question

I am working in C#, winform and Mysql. (Visual Studio 2010).

In my project all menustrip items are invisable. At the login time its visible which menustrip item user rights. For that i invisible all menu strip,. And I code for visible the menustrip items.

But its take too much time. more then 5 minutes. So I have Few Questions.

How I find this coding execution time?. (My Code Below)....
Is any special tool is there?.
How to Reduce the time with effective code?

  private void menuActive(ToolStripItemCollection items)
        {
            hp.getConnStr();
            MySqlConnection connection = new MySqlConnection(hp.myConnStr);
            MySqlCommand command = connection.CreateCommand();
            MySqlDataReader Reader;
            command.CommandText = "select menu_key from mcs_menu_rights where userid ='"+userId+"'";
            connection.Open();
            Reader = command.ExecuteReader();
            while (Reader.Read())
            {
                foreach (ToolStripMenuItem item in items)
                {
                    if (item.Name == Reader[0].ToString())
                    {
                        item.Visible = true;
                    }
                    else
                    {
                        menuActive(item.DropDown.Items);
                    }
                }
            }
            connection.Close();
        }

One way to do this is to use a tool called a profiler. There are many available for .NET. — Jason
– Jason, Commented Feb 7, 2012 at 13:47
should this code even work? You are recursively calling the function while the SqlDataReader is still open... — Zach Green
– Zach Green, Commented Feb 7, 2012 at 13:49
@zach, he creates multiple readers and connections, if the sql server supports multiple connections it'll work just fine. — hcb
– hcb, Commented Feb 7, 2012 at 13:54

weston · Accepted Answer · 2012-02-07 13:58:30Z

You could profile, but there are some definite improvements I can see straight off:

Seperate out your recusive function away from the database query. This way you query the database once. Note that it's not doing exactly the same, but I'm not sure what that table looks like so you'll have to test it.

private void menuActive(ToolStripItemCollection items) 
    { 
        hp.getConnStr(); 
        MySqlConnection connection = new MySqlConnection(hp.myConnStr); 
        MySqlCommand command = connection.CreateCommand(); 
        MySqlDataReader Reader; 
        command.CommandText = "select menu_key from mcs_menu_rights where userid ='"+userId+"'"; 
        connection.Open(); 
        Reader = command.ExecuteReader(); 
        while (Reader.Read()) 
        {
            var nameFromDB = Reader[0].ToString();
            setMenuActiveByName(items, nameFromDB);
        }
        connection.Close(); 
    }

    //This is the recursive bit, but doesn't re-enquire the database
    private void setMenuActiveByName(ToolStripItemCollection items, string name) 
    {
            foreach (ToolStripMenuItem item in items) 
            { 
                if (item.Name == name) 
                { 
                    item.Visible = true; 
                } 
                else 
                {
                    setMenuActiveByName(item.DropDown.Items, name); 
                } 
            }
    }

Hans Passant · Accepted Answer · 2012-02-07 13:52:46Z

Yes, creating a dbase connection for every single menu item is going to take a while. You'll need to avoid calling MenuActive() inside the foreach loop. Make it smarter with a little helper method:

    private static bool EnableMenuItem(ToolStripItemCollection items, string name) {
        foreach (ToolStripMenuItem item in items) {
            if (item.Name == name) {
                item.Visible = true;
                return true;
            }
            else if (item.DropDown.Items.Count > 0 {
                if (EnableMenuItem(item.DropDown.Items, name)) return true;
            }
        }
        return false;
    }

And call it like this:

        ...
        while (Reader.Read()) 
        { 
            EnableMenuItem(items, Reader[0].ToString();
        }

oleksii · Accepted Answer · 2012-02-07 14:02:46Z

Question 1 and 2

var time = TimeAction(() =>
    {
        //CODE here
    });

private static TimeSpan TimeAction(Action action)
{
    var sw = new Stopwatch();
    sw.Start();
    action.Invoke();
    sw.Stop();
    return sw.Elapsed;
}

Question 3

//One loop through all records in database
while (Reader.Read())
{
    //Another loop through all the control
    foreach (ToolStripMenuItem item in items)
    {
        if (item.Name == Reader[0].ToString())
        {
            item.Visible = true;
        }
        else
        {
            menuActive(item.DropDown.Items);
        }
    }
}

Given you have 1000 records in a database and 10 items, this take 10 000 iterations, each including trip to database to serve new data.

Zach Green · Accepted Answer · 2012-02-07 13:46:17Z

0

Use the StopWatch class to time the execution, http://msdn.microsoft.com/en-us/library/system.diagnostics.stopwatch.aspx. Log the time after each step to determine what is taking so long.

answered Feb 7, 2012 at 13:46

Zach Green

3,4605 gold badges31 silver badges32 bronze badges

Comments

Shai · Accepted Answer · 2012-02-07 13:47:05Z

0

You can use the StopWatch class for testing performance

StopWatch sWatch = new StopWatch();
sWatch.Start();
// Code comes here
...
sWatch.Stop();
// sWatch.Elapsed // Contains the time interval

It seems like you have a bad recursion there - you run the function on the same collection over and over.

answered Feb 7, 2012 at 13:47

Shai

25.7k9 gold badges48 silver badges69 bronze badges

Comments

vc 74 · Accepted Answer · 2012-02-07 13:47:27Z

0

Depending on your version of VS, you might be able to use the builtin profiling tools to find where the time is spent.

answered Feb 7, 2012 at 13:47

vc 74

38.3k7 gold badges80 silver badges96 bronze badges

Comments

Samet Atdag · Accepted Answer · 2012-02-07 13:47:46Z

0

For questions 1 and 2, you can use stopwatch:

Stopwatch watch = new Stopwatch();

watch.Start();
//YOUR CODE HERE
watch.Stop();

Console.WriteLine("Elapsed: {0}",watch.Elapsed);

answered Feb 7, 2012 at 13:47

Samet Atdag

1,0027 silver badges21 bronze badges

Collectives™ on Stack Overflow

how to find the coding execution time in c#?

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related