Codeigniter not properly processing a foreach loop

Question

I've got about 10 rows in my db and 3 of which have status == to 'Pass'. The problem I've noticed with the code below is with the foreach loop. It's not wanting to work properly. I can't even get the script to send the jSON data back to the browser which means the script isn't processing past the foreach statement. Does anybody know how to fix this?

public function logsig() {
        header('Content-type:application/json');
        $postedUser = $this->input->post('username');
        $password = $this->input->post('password');
        $hashedPass = $this->encrypt->sha1($password);
        $query = $this->db->query("SELECT * FROM users WHERE username = '{$postedUser}' AND password = '{$hashedPass}'");
        foreach ($query->result() as $row) {
            if ($row->status == "Pass") {
                if ($query->num_rows() > 0) {
                    $this->session->set_userdata('logged', "1");
                    $this->session->set_userdata("username", "{$postedUser}");
                    echo json_encode(array('session_state' => true));
                } else {
                    echo json_encode(array('session_state' => false));
                }
            } elseif ($row->status == "Fail" || "Pending") {
                exit;
            }
        }
    }

Are you sure that your query is returning any results?

Hersha
– Hersha

2012-02-10 15:47:37 +00:00
Commented Feb 10, 2012 at 15:47 — Hersha
– Hersha, Commented Feb 10, 2012 at 15:47
No right now it's not returning anything.

Michael Grigsby
– Michael Grigsby

2012-02-10 15:49:27 +00:00
Commented Feb 10, 2012 at 15:49 — Michael Grigsby
– Michael Grigsby, Commented Feb 10, 2012 at 15:49

gen_Eric · Accepted Answer · 2012-02-10 16:07:44Z

3

You're echoing the JSON in each iteration of the loop. This will make something like this:

{"session_state": true}{"session_state": false}

This is not valid JSON.

You need to build an array, and then echo json_encode() (just once) after the loop.

Also your elseif should be this:

elseif ($row->status == "Fail" || $row->status == "Pending")

edited Feb 10, 2012 at 16:07

answered Feb 10, 2012 at 15:47

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Michael Grigsby Over a year ago

Yeah I noticed that in the response header when i coded it a different way. Thanks!

Gaurav · Accepted Answer · 2012-02-10 15:47:28Z

1

Replace elseif ($row->status == "Fail" || "Pending") { with

elseif ($row->status == "Fail" || $row->status == "Pending") {

You are missing $row->status == in your second condition of elseif block

answered Feb 10, 2012 at 15:47

Gaurav

28.8k9 gold badges54 silver badges81 bronze badges

Collectives™ on Stack Overflow

Codeigniter not properly processing a foreach loop

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related