converting similar click event actions into a function?

Question

I have 4 click events that use nearly the same tracking code so I am thinking that this code would be better residing in a function, what I would like to know though is how do I set certain values that are different from event to event? Do I need to pass parameters into the new function that take on the value?

My click event code is:

$('a.close', '#contents').on('click', function(){
    s=s_gi('myapp');
    s.linkTrackVars="None"; 
    s.linkTrackEvents="None";
    s.tl(this,'o','myapp_fb:new_story:a');
});

$('a.next', '#contents').on('click', function(){
    s=s_gi('myapp');
    s.linkTrackVars="None"; 
    s.linkTrackEvents="None";
    s.tl(this,'o','myapp_fb:new_story:b');
});

$('a.prev', '#contents').on('click', function(){
    s=s_gi('myapp');
    s.linkTrackVars="None"; 
    s.linkTrackEvents="None";
    s.tl(this,'o','myapp_fb:new_story:c');
}):

$('a.share', '#contents').on('click', function(){
    s=s_gi('myapp');
    s.linkTrackVars="None"; 
    s.linkTrackEvents="None";
    s.tl(this,'o','myapp_fb:new_story:d');
});

Where's s coming from?

Brad Christie
– Brad Christie

2012-02-15 14:29:51 +00:00
Commented Feb 15, 2012 at 14:29 — Brad Christie
– Brad Christie, Commented Feb 15, 2012 at 14:29
s is coming from a separate js file supplied by omniture

styler
– styler

2012-02-15 14:34:46 +00:00
Commented Feb 15, 2012 at 14:34 — styler
– styler, Commented Feb 15, 2012 at 14:34

Didier Ghys · Accepted Answer · 2012-02-15 14:31:13Z

2

You could do something like that:

var clickHandler = function(value) {
    s=s_gi('myapp');
    s.linkTrackVars="None"; 
    s.linkTrackEvents="None";
    s.tl(this,'o',value);
}

$('a.close', '#contents').on('click', function(){
    clickHandler('myapp_fb:new_story:a');
});

answered Feb 15, 2012 at 14:31

Didier Ghys

30.6k9 gold badges77 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Brad Christie Over a year ago

I was going to go the jQuery plugin route, but that's a perfectly reasonable refactor.

Collectives™ on Stack Overflow

converting similar click event actions into a function?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related