using static method

Question

I'm unsure how to use the static method in this program. I am coding a program that will calculate a factorial of a number between 0 and 10. The user can enter the number and the program should calculate the factorial. I had originally written a functional program with all of the code coming from the main and then when I double checked the assignment rubric I noticed I was supposed to place the calculation for getting the factorial in a static method. I believe my issue is towards the bottom where I'm asking the user to enter the number I don't send it to the calculator. I guess I'm unclear on how that is done. I'm new so I apologize for my poor coding and I appreciate any help.

Here is my code:

import java.util.Scanner; //import scanner class
public class FactorialCalculator {

    public static long calculator(long fact, int num) {
        for(int i = 1; i<=num; i++) {
            fact *= i;
        }
        return fact;
    }

    public static void main(String[] args) {
        Scanner calc = new Scanner(System.in); //create new scanner calc
        int num = 0;
        long fact = 1;
        //welcome user to the Factorial Calculator
        System.out.println("Welcome to the Factorial Calculator.");
        System.out.println();
        String choice = "y";
        while (choice.equalsIgnoreCase("y")) {
            System.out.println("Please enter an integer that's greater than 0 and less than 10: ");
            num = calc.nextInt();

            System.out.println("The Factorial for " + num + " is " + fact +".");
            System.out.println();
            System.out.println("Would you like to continue? y/n");
            choice = calc.next();
            System.out.println();
        }
    }
}

As a side note - the method that calculates the factorial should only need one input parameter - get rid of the first parameter and initialize it in the method. — Michael Burr
– Michael Burr, Commented Feb 16, 2012 at 23:48
@MichaelBurr That should be done, as right now fact is not reset between loops. Keep in mind that fact has to be declared in the calculator method long fact=1; as well as in main(). — Hawken
– Hawken, Commented Feb 16, 2012 at 23:53
a static method can invoke only another static methods from the same class. Your main method is static, so if you want to call calculator it must be static too. You can refer to the static keyword here or to this post. — Luiggi Mendoza
– Luiggi Mendoza, Commented Feb 16, 2012 at 23:59
@LuiggiMendoza Thank you for the links. I have to revisit them but what I read was a little more helpful than what I was reading from. — Jeremy B
– Jeremy B, Commented Feb 17, 2012 at 1:28
@JeremyBorton sure just google java static keyword and there will be tons of info for you. Maybe you want to learn more of Java keywords and their use :D. — Luiggi Mendoza
– Luiggi Mendoza, Commented Feb 17, 2012 at 2:59

Borealid · Accepted Answer · 2012-02-16 23:45:06Z

1

Place this just before you print the result:

fact = FactorialCalculator.calculator(fact, num)

answered Feb 16, 2012 at 23:45

Borealid

99.3k9 gold badges111 silver badges123 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hawken · Accepted Answer · 2012-02-17 00:08:13Z

0

You're never calling calculator(long fact, int num);

just call it with

    fact = calculator(fact,num);

right after:

    num = calc.nextInt();

EDIT:

I would recommend you also remove the long fact as an argument to calculator() and add it into the method body of calculator()

Ex:

public static long calculator(int num){
   long fact=1;
   for(int i = 1; i<=num; i++){
      fact *= i;
   }
   return fact;
}

edited Feb 17, 2012 at 0:08

answered Feb 16, 2012 at 23:50

Hawken

2,11921 silver badges34 bronze badges

1 Comment

Jeremy B Over a year ago

I'm noticing now my calculations are off when they weren't before. in my main method I did delcare int num = 0; and long fact = 1; if I don't have that then I get errors is there a way around this?

user1188835 · Accepted Answer · 2012-02-16 23:51:17Z

0

You can call a static method of a class as:

variableType variableName = ClassName.MethodName(parameters);

In your case you can simply call:

        fact = FactorialCalculator.calculator(fact, num);

It should be inserted somewhere AFTER when you ASK the user for the input num, and BEFORE you print out the fact number to the user

answered Feb 16, 2012 at 23:51

user1188835

Comments

cb1 · Accepted Answer · 2012-02-16 23:56:57Z

0

import java.util.Scanner; //import scanner class
public class FactorialCalculator 
{

    public static long calculator(int num)
    {
            long fact = 1;

            for(int i = 1; i<=num; i++)
            {
                fact *= i;
            }
        return fact;
    }

    public static void main(String[] args)
    {
        Scanner calc = new Scanner(System.in); //create new scanner calc
        int num;
        //welcome user to the Factorial Calculator
        System.out.println("Welcome to the Factorial Calculator.");
        System.out.println();
        String choice = "y";
        while (choice.equalsIgnoreCase("y"))
            {
            System.out.println("Please enter an integer that's greater than 0 and less than 10: ");
            num = calc.nextInt();

            fact = FactorialCalculator.calculator(num);

            System.out.println("The Factorial for " + num + " is " + fact +".");

            System.out.println();
            System.out.println("Would you like to continue? y/n");
            choice = calc.next();
            System.out.println();
            }
    }
}

answered Feb 16, 2012 at 23:56

cb1

9407 silver badges16 bronze badges

1 Comment

Hawken Over a year ago

You may want to offer an explanation for what you are changing.

Bob Wang · Accepted Answer · 2012-02-16 23:58:00Z

0

Start with this:

fact = FactorialCalculator.calculator(fact, num)

And you should notice that the program will calculate factorial right for the first time, then it starts to fail since the second time. Fixing that bug is your job.

answered Feb 16, 2012 at 23:58

Bob Wang

6064 silver badges8 bronze badges

Comments

RanRag · Accepted Answer · 2012-02-16 23:59:21Z

0

As your calculator method is a static method so you can call it directly by using the class name.

num = calc.nextInt();
long result_factorial = FactorialCalculator.calcuator(fact,num)

Your method should be

public static long (int num)
        {
              long fact = 1;
                for(int i = 1; i<=num; i++)
                {
                fact *= i;
                }
            return fact;
        }

Remove the fact initialisation from your main method.

edited Feb 16, 2012 at 23:59

answered Feb 16, 2012 at 23:47

RanRag

49.8k39 gold badges119 silver badges172 bronze badges

9 Comments

MByD Over a year ago

You shouldn't create an object, it's a static method.

RanRag Over a year ago

@BinyaminSharet: I was trying to explain the difference between static and instance method but than i dropped that idea but forgot to remove my sentence.

Hawken Over a year ago

@RanRag it's in the same class, you can simply call it as calculator(); not FactorialCalculator.calcuator();

RanRag Over a year ago

@Hawken: I know that but was trying to do it the general way.What if not in same class.?

RanRag Over a year ago

@Hawken: That is how i called it. FactorialCalculator.calcuator(fact,num)

|

Collectives™ on Stack Overflow

using static method

6 Answers 6

Comments

1 Comment

Comments

1 Comment

Comments

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

Comments

1 Comment

Comments

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related