PHP script to create table

Question

I need to create MySQL table. So I'm running this script but it's just not working. Any idea why?

<?php
$con = mysql_connect("database.dcs.aber.ac.uk","xxx","nnnnnnnnnn");
mysql_select_db("jaz",$con);
$sql = "CREATE TABLE storys
(
id int NOT NULL AUTO_INCREMET,
title TINYTEXT,
type TINYTEXT,
link TEXT,
preview TINYTEXT,
tags TINYTEXT,
text MEDIUMTEXT,
updated TIMESTAMP() ON UPDATE CURRENT_TIMESTAMP,
created DATETIME() DEFAULT NULL,
PRIMARY KEY(id)
)";

mysql_query($sql,$con);

mysql_close($con);

?>

add the line echo mysql_error(); below the line mysql_query($sql, $con); and then tel me if it outputs anything, this line usually tells you what error is occuring and most likely the reason for your problem — Lennart
– Lennart, Commented Feb 22, 2012 at 15:57
this is error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ') ON UPDATE CURRENT_TIMESTAMP, created DATETIME() DEFAULT NULL, — Jakub Zak
– Jakub Zak, Commented Feb 22, 2012 at 16:00
What are these lines: updated TIMESTAMP() ON UPDATE CURRENT_TIMESTAMP, created DATETIME() DEFAULT NULL, ment to do? are you wanting a date field? — Lennart
– Lennart, Commented Feb 22, 2012 at 16:05

Marc B · Accepted Answer · 2012-02-22 15:56:40Z

4

Your code has absolute NO error handling, which would have shown you the reason the query's failing.

$con = mysql_connect(...) or die(mysql_error());

$res = mysql_query(...) or die(mysql_error());

is the bare minimum error handling you should have on pretty much every mysql call.

Had this been in place, you'd have to been told:

id int NOT NULL AUTO_INCREMET,
                            ^---missing 'n', not a valid SQL keyword.

answered Feb 22, 2012 at 15:56

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ed Meacham · Accepted Answer · 2012-02-22 16:20:30Z

0

Among the previously listed issues, you are using functions in the data type definitions, and the "ON UPDATE" syntax is wrong.

Here is what I think you are looking for in the SQL:

CREATE TABLE IF NOT EXISTS  `storys` (
 `id` INT NOT NULL AUTO_INCREMENT ,
 `title` TINYTEXT,
 `type` TINYTEXT,
 `link` TEXT,
 `preview` TINYTEXT,
 `tags` TINYTEXT,
 `text` MEDIUMTEXT,
 `updated` TIMESTAMP DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP ,
 `created` DATETIME DEFAULT NULL ,
PRIMARY KEY ( id )
);

answered Feb 22, 2012 at 16:20

Ed Meacham

5751 gold badge5 silver badges19 bronze badges

4 Comments

Ed Meacham Over a year ago

What version of MySQL are you using, and can you give the error message again, so we can be sure it is exactly the same?

Jakub Zak Over a year ago

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP , created DATE

Ed Meacham Over a year ago

Can you provide the "new" SQL you're running?

Ed Meacham Over a year ago

And perhaps this has something to do with it: stackoverflow.com/a/4897134/682232

Collectives™ on Stack Overflow

PHP script to create table

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related