PHP - MySQL Deleting a record

Question

I'm pulling records from the database and created a PHP file to execute when then "delete" button is pressed. The code works in the sense that it deletes the records from the database but it always deletes the first record in the database and not the one relating to the Request ID thats in the table. Any help would be great

Table:

<?php

    //3. Perform database query
        $result = mysql_query("SELECT * FROM Request
        WHERE DepID = 'CO'
        AND Status = 'P'", $connection);
        if(!$result){
            die("Database query failed: " . mysql_error());
        }

    //4. Use Returned Data
    while ($row = mysql_fetch_array($result)) {
    $row['ReqID'];  

        echo "<tr>";
        echo "<td class='req' align='center'>".$row['ReqID']."</td>";
        echo "<td class='req' align='center'>".$row['ModTitle']."</td>"; 
        echo "<td class='req' align='center'>".$row['BuildingID']."</td>";
        echo "<td class='req' align='center'>".$row['RoomID']."</td>";
        echo "<td class='req' align='center'>".$row['Priority']."</td>";
        echo "<td class='req' align='center'>".$row['W1']."</td>";
        echo "<td class='req' align='center'>".$row['P1']."</td>";
        echo "<td class='req' align='center'><a href=''><img height='18px' src='images/edit.png'></a></td>";
        echo "<td class='req' align='center'><a href='deletereq.php'><img src='images/exit.png'></a></td>";
        echo "</tr>";




    }
?>

And then this is the deletereq.php file:

<?php require_once("includes/connection.php"); ?>

<?php

    //3. Perform database query
        $result = mysql_query("SELECT * FROM Request
        WHERE DepID = 'CO'
        AND Status = 'P'", $connection);
        if(!$result){
            die("Database query failed: " . mysql_error());
        }

    //4. Use Returned Data
    while ($row = mysql_fetch_array($result)) {
    $row['ReqID'];


$result2 = mysql_query("DELETE FROM Request 
                       WHERE ReqID = {$row['ReqID']} LIMIT 1", $connection);
    if (mysql_affected_rows() == 1) {
                redirect_to("content.php");
            } else {
            //deletion failed
            echo "<h1>Request Deletion Failed.</h1>";
            echo "<p>" . mysql_error() . "</p>";
            echo "<a href=\"request.php\"> Return to request</a>";
        }
        }
?>

<?php mysql_close($connection); ?>

What do you expect the value of $row['ReqID'] to be where you have your delete query? — cotton.m
– cotton.m, Commented Feb 24, 2012 at 2:47
The value of the records unique ID thats comes from the sql database — ScottD
– ScottD, Commented Feb 24, 2012 at 2:49
Hmmm okay. Well I don't understand why you are surprised that it's deleting the first row. Your first code needs to passing along the request of the id you want to delete to the second page. It's not doing that. — cotton.m
– cotton.m, Commented Feb 24, 2012 at 2:53
Ahh right, how would I go about doing that then? Sorry if I sound dumb — ScottD
– ScottD, Commented Feb 24, 2012 at 2:54

cotton.m · Accepted Answer · 2012-02-24 03:00:11Z

2

On display page

echo "<td class='req' align='center'><a href='deletereq.php?id=".$row['ReqID']."'><img src='images/exit.png'></a></td>";

And on your delete page change the query to use the value of $_GET['id']

But please note that depending on your use and such here you may really want to figure out what your needs are from a security etc perspective. Additionally generally speaking using a GET for change is not a good idea, it would be better to use a POST and then a redirect. Point being the above will work but that (and what you already have) is enough that you could do some serious damage to yourself if not careful.

answered Feb 24, 2012 at 3:00

cotton.m

4553 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP - MySQL Deleting a record

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related