How to optimize my javascript?

Question

I have inherited a piece of code which has a series of functions like the following:

$("#data[User][notify_one_day_out]").change(function () {
    $("#updatenotificationsform").submit();
}

$("#data[User][notify_one_month_out]").change(function () {
    $("#updatenotificationsform").submit();
 }

and this goes on and on. How do I just write one function that does the same thing since every ID begins with data. Sorry am a JS newbie

Thanks

Isn't this just the exact same code twice? Als, #data[User][notify_one_day_out] matchs the element with ID data if the User and notify_one_day_out attributes are set. If they are part of the ID instead, you have to escape []. — Felix Kling
– Felix Kling, Commented Feb 24, 2012 at 3:09

Deleteman · Accepted Answer · 2012-02-24 03:12:21Z

4

Something like this would probably work for you:

$('[id^="data"]').change(function() {
 $("#updatenotificationsform").submit();
}

That basically says: grab all the elements with an Id starting with the string "data", you can read more about that here: http://api.jquery.com/attribute-starts-with-selector/

Let me know if that helps!

Edit

Alternatively if you can modify your mark up, you could assign the same class to all those elements, and then just select using the class selector.

answered Feb 24, 2012 at 3:12

Deleteman

8,6907 gold badges28 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

maxedison Over a year ago

The alternative solution you offer here is definitely the way to go if you have control over the html output.

Jordan Running · Accepted Answer · 2012-02-24 03:19:56Z

0

In addition to @Deleteman's sound advice, remember that you can specify multiple selectors for $(), e.g.:

$(  "#data[User][notify_one_month_out]",
    "#data[User][notify_one_day_out]",
    "#some-other-selector",
    // ...
).change(function () {
  $("#updatenotificationsform").submit();
}

answered Feb 24, 2012 at 3:19

Jordan Running

107k18 gold badges193 silver badges189 bronze badges

1 Comment

Felix Kling Over a year ago

You'd have to escape the [].

shenku · Accepted Answer · 2012-02-24 03:24:39Z

0

You can actually stack up those Jquery selectors would that be enough of a help or do you really have ALOT of them?

$("#data[User][notify_one_day_out], #data[User][notify_one_month_out]").change(function ()     
{
    $("#updatenotificationsform").submit();
}

answered Feb 24, 2012 at 3:24

shenku

12.5k14 gold badges67 silver badges126 bronze badges

Collectives™ on Stack Overflow

How to optimize my javascript?

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related