Haskell Read - no parse error

Question

I have a type called PartialDate

Then I have a function

readPartialDate :: String -> Maybe PartialDate

Bit of test code

main = do
        [d] <- getArgs
        return $ show $ readPartialDate d

runhaskell PartialDate.hs "12-2-2010"
"Just 12-2-2010"

All OK

Then I create a read simply by dispatching on readPartialDate:

instance Read PartialDate where
         readsPrec _ s = case (readPartialDate s) of
                              Nothing -> []
                              Just p -> [(p, s)]

Test code:

main = do
        [d] <- getArgs
        return $ show $ ((read d) :: PartialDate)

runHaskell PartialDate.hs 12-2-2010
PartialDate.hs: Prelude.read: no parse

Does anyone know why putting a working function into a read might give rise to a parse error?

readPartialDate uses Parsec, and also uses reverse, so might there be a laziness issue here?

Daniel Fischer · Accepted Answer · 2012-02-24 10:32:24Z

4

The problem is that in the definition of readsPrec,

 readsPrec _ s = case (readPartialDate s) of
                      Nothing -> []
                      Just p -> [(p, s)]

you give the input String itself as the second component of the readsPrec result pair. read requires that the reads result have the second component empty, meaning that the entire input has been consumed to determine the value (in general, when you write Read instances, make sure you don't forget to consume trailing whitespace). Change the instance to

 readsPrec _ s = case (readPartialDate s) of
                      Nothing -> []
                      Just p -> [(p, "")]

and it should work.

edited Feb 24, 2012 at 10:32

answered Feb 24, 2012 at 10:07

Daniel Fischer

184k19 gold badges319 silver badges436 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ivanm Over a year ago

@RobertOnslow: if this answered your question, remember to mark it as such.

Collectives™ on Stack Overflow

Haskell Read - no parse error

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related