Java-Read Text Files And Store Them As Arrays

Question

I have the following piece of code. I do not understand why its not working.

I'd really appreciate help on this.

import java.util.Scanner;
import java.io.*;

class ReadFiles {
    String [] codes = new String[99];
    int i = 0;

    private Scanner readCodes;

    public void openCodesFile() {
        try {
            readCodes = new Scanner(new File("C:/Users/Carlo/Desktop/Files/codes.txt"));
        } catch (Exception e) {
            System.out.println("Could not locate the data file!");
        }
    }

    public void readCodesFile() {

        while(readCodes.hasNext()) {
            codes[i] = readCodes.nextLine();
            i++;
            System.out.println(codes[i]);
        }
    }

    public void closeCodesFile() {
        readCodes.close();
    }
}

class NewHardware {
    public static void main(String[] args) {
        ReadFiles codesRead = new ReadFiles();
        codesRead.openCodesFile();
        codesRead.readCodesFile();
        codesRead.closeCodesFile();
    }
}

The output prints out "null" a bunch of times.

Also, I want to be able to not only print out the codes but use the codes array in the class NewHardware and manipulate it (print it out, truncate it, etc).

I was thinking of doing the following with readCodesFile():

public String readCodesFile() {

        while(readCodes.hasNext()) {
            codes[i] = readCodes.nextLine();
            i++;
            System.out.println(codes[i]);
        }
                    return (codes[i]);
    }

Or something but it hasn't worked just yet. Am I on the right track?

Oh, just wanted to add that the text contains the following:

G22
K13
S21
I30
H15
N23
L33
E19
U49

EDIT:

Thanks to Tony and Churk below to help me with my idiocy. I am accepting Tony's answer basically because he challenged me to think but Churk's answer is just as valuable.

For the second part of my question (where I asked about being able to use it in class NewHardware), I did the following:

class NewHardware {
    public static void main(String[] args) {
        ReadFiles codesRead = new ReadFiles();

        codesRead.openCodesFile();

        codesRead.readCodesFile();

        for (int i = 0; i < 9; i++) {
            System.out.println("\n\n" + codesRead.codes[i]);
        }

        codesRead.closeCodesFile();
    }
}

This is of course not the final program code but this has helped me get the basic idea. Hope this helps others too.

+1 for doing the work and asking a coherent question.

Tony Ennis
– Tony Ennis

2012-02-26 05:57:40 +00:00
Commented Feb 26, 2012 at 5:57 — Tony Ennis
– Tony Ennis, Commented Feb 26, 2012 at 5:57

Churk · Accepted Answer · 2012-02-26 06:03:40Z

2

codes[i] = readCodes.nextLine();
            i++;
            System.out.println(codes[i]);

You are printing codes[i++]

answered Feb 26, 2012 at 6:03

Churk

4,6475 gold badges25 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nico Over a year ago

Thanks for the answer, I figured it out because of Tony below and then read your answer and comment.

Tony Ennis · Accepted Answer · 2012-02-26 05:54:20Z

1

Look carefully at your readCodesFile() method. Look at every line. What is it doing? Can you explain it to us?

answered Feb 26, 2012 at 5:54

Tony Ennis

12.4k8 gold badges59 silver badges79 bronze badges

2 Comments

Nico Over a year ago

Well, I was hoping it would be adding the codes from the text file to the array. I am new to this, never done it, so I can't really understand what I am doing wrong. I know there is something wrong but just don't know what it is. Hence I posted it here to get some sort of direction.

Tony Ennis Over a year ago

Ok, " codes[i] = readCodes.nextLine();" reads a line and jams it into codes[i]. Then "i++" increments the index. What happens now with the println??

Collectives™ on Stack Overflow

Java-Read Text Files And Store Them As Arrays

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related