ReturnUrl in asp.net mvc is null for some reason

Question

public ActionResult LogOn(string returnUrl)
        {
            if (Request.IsAuthenticated)
            {
                return RedirectToAction(string.Empty, "home");
            }
            else
            {
                if (!string.IsNullOrWhiteSpace(returnUrl))
                {
               //http://localhost:666/en-us/account/logon?returnurl=%2fen-us%2fadminka
                     //..............
                }
                return View();

            }
        }

        [HttpPost]
        public ActionResult LogOn(LogOnViewModel model, string returnUrl)
        {
            if (ModelState.IsValid)
            {
                if (....)
                {
                    //..............
                    if (Url.IsLocalUrl(returnUrl) && returnUrl.Length > 1 && returnUrl.StartsWith("/")
                        && !returnUrl.StartsWith("//") && !returnUrl.StartsWith("/\\"))
                        return Redirect(returnUrl);
                    return RedirectToAction(string.Empty, "home");

                }
                else
                {
                    //..............
                }
            }

            return View(model);
        }

In HttpPost LogOn returnUrl is always equals null, even if it was not null in HttpGet LogOn.

Why? How do I fix it?

Oved D · Accepted Answer · 2012-02-27 18:14:22Z

You need the returnUrl to be posted with the form post.

Probably the cleanest solution is to add returnUrl as a property to the LogOnViewModel:

    public class LogOnViewModel
{
    public string UserName { get; set; }
    public string Password { get; set; }
    public string ReturnUrl { get; set; }
}

Your get method would set that value:

[HttpGet]
public ActionResult LogOn(string returnUrl)
    {
       // code for already authenticated case left out for demo
            var model = new LogOnViewModel { ReturnUrl = returnUrl };
            return View(model);

        }
    }

In your form, you would persist that value as a hidden field:

@using (Html.BeginForm())
{
    @Html.HiddenFor(model => model.ReturnUrl)

    // rest of form code left out for demo purposes
}

Your post method would then have access to that value:

    [HttpPost]
    public ActionResult LogOn(LogOnViewModel model)
    {
        if (ModelState.IsValid)
        {
            if (....)
            {   string returnUrl = model.ReturnUrl;

                //..............
                if (Url.IsLocalUrl(returnUrl) && returnUrl.Length > 1 && returnUrl.StartsWith("/")
                    && !returnUrl.StartsWith("//") && !returnUrl.StartsWith("/\\"))
                    return Redirect(returnUrl);
                return RedirectToAction(string.Empty, "home");

            }
            else
            {
                //..............
            }
        }

        return View(model);
    }

Community · Accepted Answer · 2017-05-23 12:30:19Z

2

In your login view, add the ReturnUrl parameter to the form action. For instance:

BeginForm("LogOn", "Account", new {ReturnUrl = Request.QueryString["ReturnUrl"]})

See davewasthere's answer.

edited May 23, 2017 at 12:30

CommunityBot

11 silver badge

answered Jun 26, 2012 at 1:34

Fernando Correia

22.5k14 gold badges87 silver badges119 bronze badges

Comments

Softlion · Accepted Answer · 2012-02-27 10:52:08Z

0

When in the LogOn view verify that :

either the url contains "returnUrl"
or there is a returnUrl field in the form

answered Feb 27, 2012 at 10:52

Softlion

12.7k11 gold badges63 silver badges91 bronze badges

3 Comments

Alexandre Over a year ago

<<either the url contains "returnUrl">> I'm sorry, what do you mean? There's ?returnurl= parameter in the first action LogOn(string returnUrl) and in the Url too.

Alexandre Over a year ago

The form doesn't have a returnUrl field.

Softlion Over a year ago

You should add a returnUrl field in your form then.

Collectives™ on Stack Overflow

ReturnUrl in asp.net mvc is null for some reason

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related