wrong output code

Question

The following code gives the wrong binary output: The input is a HEX number and the output should be a binary number.

It always outputs:

How can I change it so it outputs the right binary number?

#include <iostream>

using namespace std;

int main ()
{   

int Number;
cin >> Number;
bool Binary[sizeof(int) * CHAR_BIT];

for(unsigned int i = 0; i < sizeof(int) * CHAR_BIT; i++)
    Binary[(sizeof(int) * CHAR_BIT - 1) - i] = Number & (1 << i);

for(unsigned int i = 0; i < sizeof(int); i++)
    std::cout << Binary[i] << std::endl;

system ("pause");

return 0;

}

"wrong output" does not reflect the problem to a sufficiently descriptive degree. It should aid somebody to find this post in a web search in the future. — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Mar 7, 2012 at 10:17

taskinoor · Accepted Answer · 2012-03-07 09:44:59Z

1

You are calculating it right but printing only sizeof(int) bits, not all bits. In last print loop use i < sizeof(int) * CHAR_BIT.

for(unsigned int i = 0; i < sizeof(int) * CHAR_BIT; i++)
    std::cout << Binary[i] << std::endl;

answered Mar 7, 2012 at 9:44

taskinoor

46.1k13 gold badges118 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

wrong output code

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related