how to loop through a list of byte arrays...?

Question

if i have a list of byte arrays, and i want to delete an array if the first index is a specific value, how would i use something like this:

bytearrays.removeAll(Collections.singletonList(-7));

if this is not possible, what would be the best way to go about this? I've tried using iterators, but i don't think i understand them enough to be able to force it to check the first index of each array in the list of arrays...

when i simply create a for loop, for some reason some of the arrays are not deleted(usually the last array, sometimes the last 2 depending on how many arrays).

You are changing the size when you remove things from it, but you don't change the size — Peter Lawrey
– Peter Lawrey, Commented Mar 8, 2012 at 10:31

Andrzej Doyle · Accepted Answer · 2012-03-08 10:29:06Z

4

The majority of lists have an iterator that correctly implements the remove method.

Given that the simplest solution would be something like the following:

final Iterator<byte[]> iter = bytearrays.iterator();
while (iter.hasNext()) {
    final byte[] temp = iter.next();
    // TODO check for zero-length arrays
    if (temp[0] == -7) {
        iter.remove();
    }
}

answered Mar 8, 2012 at 10:29

Andrzej Doyle

104k33 gold badges191 silver badges231 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

BigBug Over a year ago

this answer is pretty kick ass. didn't think of user byte[] temp this way... pretty neat. thanks man. +1 and best answer

Aleks G · Accepted Answer · 2012-03-08 10:28:56Z

2

Your main issue is that you're looping from the first to the (last-2) element in the array, but when you delete an element, all other elements shift. Instead, you should loop in the reverse order:

for(int z = bytearray.size() - 1; z >=0 ; z--)
{
    byte[] temp = bytearrays.get(z);
    if(temp[0] == -16 || temp[0] == -11 || temp[0] == -7)
    {
        bytearrays.remove(z); 
    }
}

I'm not sure why you're removing the first element of the array regardless of other conditions, but you can add that line before the loop, if you need to.

answered Mar 8, 2012 at 10:28

Aleks G

57.5k34 gold badges180 silver badges280 bronze badges

Comments

jack smith · Accepted Answer · 2012-03-08 10:35:48Z

0

You are not supposed to remove from a List while iterating it cause removing an entry cause the List to change - it shifts the rest of the list, so also the size of the list changes. You better use an Iterator to remove. Anyway, pay attention that if you iterate over in with a loop that its stop-condition is on the list's length then consider that it changes. This is also resolved by the hasNext() method of Iterator.

answered Mar 8, 2012 at 10:35

jack smith

7117 silver badges16 bronze badges

Collectives™ on Stack Overflow

how to loop through a list of byte arrays...?

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related