PHP Foreach Loop not using break

Question

I want to create this loop

<li class="royalSlide">
    <div class="celebFixSlider">
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
    </div>
</li>

<li class="royalSlide">
    <div class="celebFixSlider">
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
        <a href=""><img src="" /></a>
    </div>
</li>

The LI and DIV elements are the first loop, the links are 6 row blocks per the Array.

$imagePath="//site.com/images/celeb1208/";
$productPath="//site.com/product.php?prodref=";
$array = array(
    "632_white" => "celeb1208_317_large.jpg",
     "631_white" => "celeb1208_316_large.jpg",
     "630_white" => "celeb1208_315_large.jpg",
     "629_white" => "celeb1208_314_large.jpg",
     "628_white" => "celeb1208_313_large.jpg",
     "627_white" => "celeb1208_312_large.jpg",
     "532_white" => "celeb1208_311_large.jpg",
     "531_white" => "celeb1208_310_large.jpg",
     "530_white" => "celeb1208_309_large.jpg",
     "529_white" => "celeb1208_308_large.jpg",
     "528_white" => "celeb1208_307_large.jpg",
     "527_white" => "celeb1208_306_large.jpg"
);

$i=0;
foreach ($array as $key => $val)
{      
  $i++; 

        echo '
        <li class="royalSlide">
            <div class="celebFixSlider">
                <a href="'.$productPath.''.$key.'">
                <img src="'.$val.'" />
        </a>';
       if($i==6){
            echo '</div>
            </li>';
            break;            
        }

}

After 6 items, the break just stops the code, it does not pause and recreate the loop within side?? Sorry if I am not clear.

You are not clear... Anyway, break is doing what it's supposed to: exiting the loop. — bfavaretto
– bfavaretto, Commented Mar 13, 2012 at 15:02
what are you trying to achieve with this good. please explain in details. break statement will cause to exit from the for loop as well. what do you expect??, — Juvanis
– Juvanis, Commented Mar 13, 2012 at 15:02
I want to create the block of code above, so it creates a LI and DIV with 6 items every 6 — TheBlackBenzKid
– TheBlackBenzKid, Commented Mar 13, 2012 at 15:04

TheBlackBenzKid · Accepted Answer · 2012-03-13 19:01:21Z

3

// getting data ready
foreach ($array as $key => $val) {
  $array[$key] = array(
    "href" => $productPath.$key,
    "img"  => $imagePath.$val
  );
}
$data = array_chunk($array,2);

// printing it out
?>
<?php foreach ($data as $array): ?>
<li class="royalSlide">
    <div class="celebFixSlider">
<?php   foreach ($array as $row): ?>
        <a href="<?=$row['href']?>"><img src="<?=$row['img']?>" /></a>
<?php   endforeach ?>
    </div>
</li>
<?php endforeach ?>

edited Mar 13, 2012 at 19:01

TheBlackBenzKid

27.2k45 gold badges142 silver badges214 bronze badges

answered Mar 13, 2012 at 15:10

Your Common Sense

158k42 gold badges226 silver badges373 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

TheBlackBenzKid Over a year ago

Like the name change. And this is some smart code, cant believe I did not approach it like this.

Your Common Sense Over a year ago

Aha thanks. It's always hard to spot these typos when writing in the textarea without running the code :)

roychri · Accepted Answer · 2012-03-13 15:14:22Z

3

The break; command will stop the loop completly. Maybe you want continue; that will skip what is after the continue keyword and loop again from where it left off.

What you need is no break and no continue.:

$i=0;
echo '<li class="royalSlide"><div class="celebFixSlider">';
foreach ($array as $key => $val)
{
  $i++;
    echo '
            <a href="'.$productPath.''.$key.'">
            <img src="'.$val.'" />
    </a>';
   if($i==6){
        echo '</div>
        </li><li class="royalSlide"><div class="celebFixSlider">';
    }

}
echo '</div></li>';

edited Mar 13, 2012 at 15:14

answered Mar 13, 2012 at 15:02

roychri

2,9541 gold badge23 silver badges29 bronze badges

1 Comment

ThiefMaster Over a year ago

continue doesn't make much more sense than break at this point. Actually, it makes less sense since it's a no-op in this case.

Emad Samir Zaki · Accepted Answer · 2012-03-13 15:03:27Z

2

Use "continue" instead of "break";

Break will stop the loop

Thanks

answered Mar 13, 2012 at 15:03

Emad Samir Zaki

4133 silver badges10 bronze badges

Comments

Michal · Accepted Answer · 2012-03-13 15:08:50Z

0

So you should use this:

 echo '<li class="royalSlide">
        <div class="celebFixSlider">';

 $i=0;
 foreach ($array as $key => $val)
 {
   $i++; 

    echo '
            <a href="'.$productPath.''.$key.'">
            <img src="'.$val.'" />
    </a>';
   if($i==6){
        echo '</div>
        </li>
        <li class="royalSlide">
              <div class="celebFixSlider">';
    }

 }

answered Mar 13, 2012 at 15:08

Michal

3,3524 gold badges33 silver badges51 bronze badges

Comments

user1006426 · Accepted Answer · 2012-03-13 15:14:04Z

0

Try this for your loop instead

$i=0;
foreach ($array as $key => $val)
{      
  $i++;
  if(($i % 6) == 0){
    echo '<li class="royalSlide"><div class="celebFixSlider">';
  }

  echo '<a href="'.$productPath.''.$key.'"><img src="'.$val.'" /></a>';

  if(($i % 6) == 0 && $i!=0){
    echo '</div></li>';
  }
}

edited Mar 13, 2012 at 15:14

answered Mar 13, 2012 at 15:08

user1006426

4131 gold badge5 silver badges14 bronze badges

Collectives™ on Stack Overflow

PHP Foreach Loop not using break

5 Answers 5

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related