Java, how to replace some characters in String

Question

I have an array that keeps URL addresses in String format for me. Before loading URLs, I need to make sure that there is no space in strings. I wrote this code but ReplaceAll() doesn't change anything.

Please tell me what is wrong here?

public NewsFeedItemList getNewsList() {
        String str;

        for(int i=0; i<newsFeedItemList.getImage().size(); i++){
            str = newsFeedItemList.getImage().get(i);
            Log.i("before>>>", str);
            str.replaceAll(" ", "%20");
            Log.i("after<<<<", str);
            newsFeedItemList.getImage().set(i, str);
        }

        return newsFeedItemList;
    }

Actually when i test my android app, it crashed. When i checked the log it showed me that one of urls is like this: "mania.com.my/Portals/1/hazama_news 20(1).jpg" When i put it in browser, browser changed it to "mania.com.my/Portals/1/hazama_news%20(1).jpg". I put above code in somewhere in my app but nothing will change. — Hesam
– Hesam, Commented Mar 14, 2012 at 8:06
suggestion dont use replace method, using str = URLEncoder.encode(str) — idiottiger
– idiottiger, Commented Mar 14, 2012 at 8:09

ftr · Accepted Answer · 2012-03-14 08:03:28Z

7

Strings are immutable, meaning that you cannot change the contents of a String object. What you would need to do is something like

String cleanedString = str.replaceAll(" ", "%20");

The replaceAll()-Method returns the new String.

answered Mar 14, 2012 at 8:03

ftr

2,15516 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jugal Shah · Accepted Answer · 2012-03-14 08:04:27Z

2

String is immutable, so you need to assign it back like this: str = str.replaceAll(" ", "%20");

answered Mar 14, 2012 at 8:04

Jugal Shah

3,7051 gold badge27 silver badges35 bronze badges

Comments

mohlendo · Accepted Answer · 2012-03-14 08:11:48Z

2

As already said by the other posters: String is immutable so you have to assign the return value of replaceAll to String.

Just as a hint: you should take a look at java.net.URLEncoder: http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLEncoder.html

This class helps you to format the url in a correct way and can handle all kinds of special characters - not only spaces.

answered Mar 14, 2012 at 8:11

mohlendo

56410 silver badges24 bronze badges

Comments

Deva · Accepted Answer · 2012-03-14 08:06:07Z

1

You just need to replace the line

str.replaceAll(" ", "%20");

with

str=str.replaceAll(" ", "%20");

answered Mar 14, 2012 at 8:06

Deva

3,9691 gold badge29 silver badges38 bronze badges

Comments

Lucifer · Accepted Answer · 2012-03-14 08:10:49Z

1

Updated your code with the following code,

public NewsFeedItemList getNewsList() { String str;

    for(int i=0; i<newsFeedItemList.getImage().size(); i++){
        str = newsFeedItemList.getImage().get(i);
        Log.i("before>>>", str);
        str = str.replaceAll(" ", "%20");  // I have update here
        Log.i("after<<<<", str);
        newsFeedItemList.getImage().set(i, str);
    }

    return newsFeedItemList;
}

answered Mar 14, 2012 at 8:10

Lucifer

29.7k25 gold badges93 silver badges144 bronze badges

Comments

idiottiger · Accepted Answer · 2012-03-14 08:12:11Z

1

suggestion dont use replace method,

using str = URLEncoder.encode(str),

sometimes not only the space and have another need changed character.

answered Mar 14, 2012 at 8:12

idiottiger

5,1752 gold badges27 silver badges21 bronze badges

Collectives™ on Stack Overflow

Java, how to replace some characters in String

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related