Multiple selectors when using a variable

Question

Within an .each(function(), I'm trying to uncheck checkboxes.
In line 1, I'm setting the value on 2 different Id's and this works fine. What I want to do, is to unset both of the checkboxes on a single line. i.e take lines 3 & 4 and combine into 1 line. Line 2 is what I've tried, but it's not working (it doesn't do either of them).
(The 'wsSeq' is created by the server side, so that I get unique ID's on multiple rows).

            $('#wsDocRef,#wsSupp').val('');
//          $("'#wsTransferToQuarantine" + wsSeq + ",#wsTransferToSupplier" + wsSeq + "'").attr('checked', false);
            $('#wsTransferToQuarantine' + wsSeq).attr('checked', false);
            $('#wsTransferToSupplier' + wsSeq).attr('checked', false);

lonesomeday · Accepted Answer · 2012-03-14 12:21:13Z

1

$("'#wsTransferToQuarantine" + wsSeq + ",#wsTransferToSupplier" + wsSeq + "'").attr('checked', false);

That isn't too far off, except for the unnecessary quotes. If wsSeq is 1, your selector looks like this:

$("'#wsTransferToQuarantine1,#wsTransferToSupplier1'").attr('checked', false);

Which is fine, except for the ' at each end. This should work fine:

$("#wsTransferToQuarantine" + wsSeq + ",#wsTransferToSupplier" + wsSeq).attr('checked', false);

With all that said, however, it may actually be quicker to do two ID selections than one multiple selection. This kind of optimisation is probably not necessary or a good use of your time.

answered Mar 14, 2012 at 12:21

lonesomeday

239k54 gold badges330 silver badges329 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Keith Over a year ago

When you say quicker, do you mean that the navigation of the DOM will be faster with 2 individual statements, rather than combining into 1 line? I assumed that by coding them together, that would be more the 'standards' of jquery.

lonesomeday Over a year ago

@Keith Yes, quite plausibly – though you'd have to benchmark it, and that's more effort than it's worth. One ID selection can be handled by getElementById, which is ridiculously fast, while two has to be handled by querySelectorAll, which is only very fast.

Keith Over a year ago

Thanks. Wasn't aware of that. Oh well, I'll leave the 2 lines in there then but the question was answered....

Nicola Peluchetti · Accepted Answer · 2012-03-14 12:20:21Z

0

Have you tried

$('#wsTransferToQuarantine' + wsSeq +',#wsTransferToSupplier' + wsSeq ).prop('checked', false);

You were just using two extra quotes in your call that are not needed

answered Mar 14, 2012 at 12:20

Nicola Peluchetti

76.9k32 gold badges150 silver badges197 bronze badges

Collectives™ on Stack Overflow

Multiple selectors when using a variable

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related